Re: [Intel-xe] [PATCH 6/6] fixup! drm/xe: Add frontbuffer setter/getter for xe_bo

["Govindapillai, Vinod" <vinod.govindapillai@intel.com>]

On Fri, 2023-09-15 at 13:57 +0300, Jouni Högander wrote:
> i915 frontbuffer setter and getter are moved into separate header file. We
> need to do same for Xe frontbuffer setter and getter.
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  .../gem/i915_gem_object_frontbuffer.h                | 12 ++++++++++++
>  drivers/gpu/drm/xe/xe_bo.h                           |  3 ---
>  2 files changed, 12 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object_frontbuffer.h

Looks good to me,

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> 
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object_frontbuffer.h
> b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object_frontbuffer.h
> new file mode 100644
> index 000000000000..227965e5f784
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object_frontbuffer.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#ifndef _I915_GEM_OBJECT_H_
> +#define _I915_GEM_OBJECT_H_
> +
> +#define i915_gem_object_get_frontbuffer(obj)           NULL
> +#define i915_gem_object_set_frontbuffer(obj, front)    (front)
> +
> +#endif
> diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
> index 4a68d869b3b5..9097bcc13209 100644
> --- a/drivers/gpu/drm/xe/xe_bo.h
> +++ b/drivers/gpu/drm/xe/xe_bo.h
> @@ -305,9 +305,6 @@ static inline unsigned int xe_sg_segment_size(struct device *dev)
>         return round_down(max / 2, PAGE_SIZE);
>  }
>  
> -#define i915_gem_object_get_frontbuffer(obj)           NULL
> -#define i915_gem_object_set_frontbuffer(obj, front)    (front)
> -
>  #if IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST)
>  /**
>   * xe_bo_is_mem_type - Whether the bo currently resides in the given