From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Govindapillai, Vinod" <vinod.govindapillai@intel.com>
Subject: Re: [Intel-xe] [PATCH 1/6] Revert "FIXME: drm/i915: include intel_frontbuffer.h from skl_universal_plane.c"
Date: Tue, 19 Sep 2023 05:39:20 +0000 [thread overview]
Message-ID: <fbdb146cfcea0dd1bb147a669836081cccda7e5c.camel@intel.com> (raw)
In-Reply-To: <826cdfdb62b6033f60aeaa9d6384b3d92a4e81fc.camel@intel.com>
On Mon, 2023-09-18 at 20:54 +0000, Govindapillai, Vinod wrote:
> On Fri, 2023-09-15 at 13:57 +0300, Jouni Högander wrote:
> > This reverts commit c3e942a06433e8c538108f24b4fe78a0927e2aea.
> >
> > We are about to backport upstream changes that is taking care of
> > including
> > intel_frontbuffer.h as necessary.
> >
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
>
> Hi Jouni,
>
> Should these reverts be moved after the patch 4 in this series? Won't
> that cause build failure? Or
> the patch description is not accurate?
I choose this approach as backporting patch 4 would have lots of
conflicts if backporting it first. On next rebase all these patches
will disappear anyways.
BR,
Jouni Högander
>
> With that checked,
>
> Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>
> > drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index 4d01c7ae4485..2ded1bcce754 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -16,7 +16,6 @@
> > #include "intel_display_types.h"
> > #include "intel_fb.h"
> > #include "intel_fbc.h"
> > -#include "intel_frontbuffer.h"
> > #include "intel_psr.h"
> > #include "skl_scaler.h"
> > #include "skl_universal_plane.h"
>
next prev parent reply other threads:[~2023-09-19 5:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 10:57 [Intel-xe] [PATCH 0/6] Backport patches reorganizing intel_frontbuffer.h/i915_gem_object.h Jouni Högander
2023-09-15 10:57 ` [Intel-xe] [PATCH 1/6] Revert "FIXME: drm/i915: include intel_frontbuffer.h from skl_universal_plane.c" Jouni Högander
2023-09-18 20:54 ` Govindapillai, Vinod
2023-09-19 5:39 ` Hogander, Jouni [this message]
2023-09-19 6:42 ` Govindapillai, Vinod
2023-09-19 11:09 ` Hogander, Jouni
2023-09-15 10:57 ` [Intel-xe] [PATCH 2/6] Revert "FIXME: drm/i915/psr: include intel_frontbuffer.h from intel_psr.c" Jouni Högander
2023-09-18 20:54 ` Govindapillai, Vinod
2023-09-15 10:57 ` [Intel-xe] [PATCH 3/6] Revert "FIXME: drm/i915/drrs: include intel_frontbuffer.h from intel_drrs.c" Jouni Högander
2023-09-18 20:55 ` Govindapillai, Vinod
2023-09-15 10:57 ` [Intel-xe] [PATCH 4/6] drm/i915: add minimal i915_gem_object_frontbuffer.h Jouni Högander
2023-09-18 20:56 ` Govindapillai, Vinod
2023-09-15 10:57 ` [Intel-xe] [PATCH 5/6] fixup! drm/i915/display: Move releasing gem object away from fb tracking Jouni Högander
2023-09-18 20:57 ` Govindapillai, Vinod
2023-09-15 10:57 ` [Intel-xe] [PATCH 6/6] fixup! drm/xe: Add frontbuffer setter/getter for xe_bo Jouni Högander
2023-09-18 20:57 ` Govindapillai, Vinod
2023-09-15 11:00 ` [Intel-xe] ✓ CI.Patch_applied: success for Backport patches reorganizing intel_frontbuffer.h/i915_gem_object.h Patchwork
2023-09-15 11:00 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-15 11:01 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-15 11:08 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-15 11:09 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-15 11:10 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-15 11:42 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbdb146cfcea0dd1bb147a669836081cccda7e5c.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox