Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Check skip_guc_pc before setting SLPC flag
@ 2023-12-22 21:01 Vinay Belgaumkar
  2023-12-22 23:27 ` Lucas De Marchi
                   ` (15 more replies)
  0 siblings, 16 replies; 20+ messages in thread
From: Vinay Belgaumkar @ 2023-12-22 21:01 UTC (permalink / raw)
  To: intel-xe

Don't set SLPC GuC feature ctl flag if skip_guc_pc is true.

Fixes: 975e4a3795d4 ("drm/xe: Manually setup C6 when skip_guc_pc is set")
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 drivers/gpu/drm/xe/xe_guc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 811e8b201270..0e112b144ec8 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -62,7 +62,12 @@ static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 
 static u32 guc_ctl_feature_flags(struct xe_guc *guc)
 {
-	return GUC_CTL_ENABLE_SLPC;
+	u32 flags = 0;
+
+	if (!(guc_to_xe(guc))->info.skip_guc_pc)
+		flags |= GUC_CTL_ENABLE_SLPC;
+
+	return flags;
 }
 
 static u32 guc_ctl_log_params_flags(struct xe_guc *guc)
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2024-01-05  0:36 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-22 21:01 [PATCH] drm/xe: Check skip_guc_pc before setting SLPC flag Vinay Belgaumkar
2023-12-22 23:27 ` Lucas De Marchi
2024-01-03 16:52 ` ✓ CI.Patch_applied: success for drm/xe: Check skip_guc_pc before setting SLPC flag (rev2) Patchwork
2024-01-03 16:52 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-03 16:53 ` ✓ CI.KUnit: success " Patchwork
2024-01-03 17:01 ` ✓ CI.Build: " Patchwork
2024-01-03 17:01 ` ✓ CI.Hooks: " Patchwork
2024-01-03 17:03 ` ✓ CI.checksparse: " Patchwork
2024-01-03 17:38 ` ✓ CI.BAT: " Patchwork
2024-01-04  4:56 ` [PATCH] drm/xe: Check skip_guc_pc before setting SLPC flag Nilawar, Badal
2024-01-04  6:06   ` Belgaumkar, Vinay
2024-01-04  6:15     ` Nilawar, Badal
2024-01-05  0:36       ` Belgaumkar, Vinay
2024-01-04  9:34 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-04  9:35 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-04  9:36 ` ✓ CI.KUnit: success " Patchwork
2024-01-04  9:43 ` ✓ CI.Build: " Patchwork
2024-01-04  9:44 ` ✓ CI.Hooks: " Patchwork
2024-01-04  9:45 ` ✓ CI.checksparse: " Patchwork
2024-01-04 10:20 ` ✓ CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox