Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/display: Don't allow tile4 framebuffer to do hflip on display20 or greater
@ 2024-10-07 18:28 Juha-Pekka Heikkila
  2024-10-07 21:29 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (16 more replies)
  0 siblings, 17 replies; 19+ messages in thread
From: Juha-Pekka Heikkila @ 2024-10-07 18:28 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: Juha-Pekka Heikkila

On display ver 20 onwards tile4 is not supported with horizontal flip

Bspec: 69853

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 drivers/gpu/drm/i915/display/intel_fb.c            | 13 +++++++++++++
 drivers/gpu/drm/i915/display/intel_fb.h            |  1 +
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 11 +++++++++++
 3 files changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 6c2679e6c980..735fba73c9ad 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -439,6 +439,19 @@ bool intel_fb_needs_64k_phys(u64 modifier)
 				      INTEL_PLANE_CAP_NEED64K_PHYS);
 }
 
+/**
+ * intel_fb_is_tile4_modifier: Check if a modifier is a tile4 modifier type
+ * @modifier: Modifier to check
+ *
+ * Returns:
+ * Returns %true if @modifier is a tile4 modifier.
+ */
+bool intel_fb_is_tile4_modifier(u64 modifier)
+{
+	return plane_caps_contain_any(lookup_modifier(modifier)->plane_caps,
+				      INTEL_PLANE_CAP_TILING_4);
+}
+
 static bool check_modifier_display_ver_range(const struct intel_modifier_desc *md,
 					     u8 display_ver_from, u8 display_ver_until)
 {
diff --git a/drivers/gpu/drm/i915/display/intel_fb.h b/drivers/gpu/drm/i915/display/intel_fb.h
index 8240febff84c..d78993e5eb62 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.h
+++ b/drivers/gpu/drm/i915/display/intel_fb.h
@@ -36,6 +36,7 @@ bool intel_fb_is_ccs_modifier(u64 modifier);
 bool intel_fb_is_rc_ccs_cc_modifier(u64 modifier);
 bool intel_fb_is_mc_ccs_modifier(u64 modifier);
 bool intel_fb_needs_64k_phys(u64 modifier);
+bool intel_fb_is_tile4_modifier(u64 modifier);
 
 bool intel_fb_is_ccs_aux_plane(const struct drm_framebuffer *fb, int color_plane);
 int intel_fb_rc_ccs_cc_plane(const struct drm_framebuffer *fb);
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 9207b7e96974..4755a0672739 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1619,6 +1619,17 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
 		return -EINVAL;
 	}
 
+	/*
+	 * Display20 onward tile4 hflip is not supported
+	 */
+	if (rotation & DRM_MODE_REFLECT_X &&
+	    intel_fb_is_tile4_modifier(fb->modifier) &&
+	    DISPLAY_VER(dev_priv) >= 20) {
+		drm_dbg_kms(&dev_priv->drm,
+			    "horizontal flip is not supported with tile4 surface formats\n");
+		return -EINVAL;
+	}
+
 	if (drm_rotation_90_or_270(rotation)) {
 		if (!intel_fb_supports_90_270_rotation(to_intel_framebuffer(fb))) {
 			drm_dbg_kms(&dev_priv->drm,
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2024-10-14 13:17 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 18:28 [PATCH] drm/i915/display: Don't allow tile4 framebuffer to do hflip on display20 or greater Juha-Pekka Heikkila
2024-10-07 21:29 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-07 21:29 ` ✓ CI.checkpatch: " Patchwork
2024-10-07 21:31 ` ✓ CI.KUnit: " Patchwork
2024-10-07 21:42 ` ✓ CI.Build: " Patchwork
2024-10-07 21:44 ` ✓ CI.Hooks: " Patchwork
2024-10-07 21:46 ` ✗ CI.checksparse: warning " Patchwork
2024-10-07 22:09 ` ✓ CI.BAT: success " Patchwork
2024-10-08  7:55 ` [PATCH] " Pottumuttu, Sai Teja
2024-10-08  9:02 ` ✗ CI.FULL: failure for " Patchwork
2024-10-09 18:08 ` ✓ CI.Patch_applied: success for drm/i915/display: Don't allow tile4 framebuffer to do hflip on display20 or greater (rev2) Patchwork
2024-10-09 18:08 ` ✓ CI.checkpatch: " Patchwork
2024-10-09 18:11 ` ✓ CI.KUnit: " Patchwork
2024-10-09 18:22 ` ✓ CI.Build: " Patchwork
2024-10-09 18:24 ` ✓ CI.Hooks: " Patchwork
2024-10-09 18:26 ` ✗ CI.checksparse: warning " Patchwork
2024-10-09 19:06 ` ✓ CI.BAT: success " Patchwork
2024-10-10  6:29 ` ✗ CI.FULL: failure " Patchwork
2024-10-14 13:17   ` Juha-Pekka Heikkila

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox