Re: [PATCH v6 1/3] drm/xe/vf: Enable VF migration only on supported GuC versions

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 11/24/2025 5:07 PM, Satyanarayana K V P wrote:
> Enable VF migration starting with GuC 70.54.0 (compatibility version
> 1.27.0) which supports additional VF2GUC_RESFIX_START message required
> to handle migration recovery in a more robust way.
> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Tomasz Lis <tomasz.lis@intel.com>
> 
> ---
> V5 -> V6:
> - Fixed review comments (Michal W).
> - Updated commit message.
> - return xe_sriov_vf_migration_supported() from vf_migration_init_late().
> 
> V4 -> V5:
> - Created new function vf_migration_init_late() (Michal W).
> 
> V3 -> V4:
> - New commit
> 
> V2 -> V3:
> - None.
> 
> V1 -> V2:
> - None.
> ---
>  drivers/gpu/drm/xe/xe_sriov_vf.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c
> index 284ce37ca92d..f53d68f2f1d2 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_vf.c
> @@ -170,6 +170,22 @@ void xe_sriov_vf_init_early(struct xe_device *xe)
>  	vf_migration_init_early(xe);
>  }
>  
> +static bool vf_migration_init_late(struct xe_device *xe)
> +{
> +	struct xe_gt *gt = xe_root_mmio_gt(xe);
> +	struct xe_uc_fw_version guc_version;
> +

hmm, I'm wondering whether we should do anything here if migration was already disabled at some earlier point

this can be already observed on ADLP [1] where we have two messages:

<5> [420.828841] xe 0000:00:02.1: [drm] VF: migration disabled: requires memory-based IRQ support
...
<5> [420.910616] xe 0000:00:02.1: [drm] VF: migration disabled: requires GuC ABI >= 1.27.0, but only 1.24.4 found

maybe this function should look like:

int vf_migration_init_late(...)
{
	if (!xe_sriov_vf_migration_supported(xe))
		return 0;

	if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 27, 0)) {
		xe_sriov_vf_migration_disable(xe,
					      "requires GuC ABI >= 1.27.0, but only %u.%u.%u found",
					      guc_version.major, guc_version.minor,
					      guc_version.patch);
		return 0;
	}

  	return xe_sriov_vf_ccs_init(xe);
}

including VF CCS since it is still part of the 'migration' feature, right

[1] https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156339v6/bat-adlp-7/igt@sriov_basic@enable-vfs-autoprobe-on.html


> +	xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version);
> +	if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 27, 0)) {
> +		xe_sriov_vf_migration_disable(xe,
> +					      "requires GuC ABI >= 1.27.0, but only %u.%u.%u found",
> +					      guc_version.major, guc_version.minor,
> +					      guc_version.patch);
> +	}
> +
> +	return xe_sriov_vf_migration_supported(xe);
> +}
> +
>  /**
>   * xe_sriov_vf_init_late() - SR-IOV VF late initialization functions.
>   * @xe: the &xe_device to initialize
> @@ -180,6 +196,9 @@ void xe_sriov_vf_init_early(struct xe_device *xe)
>   */
>  int xe_sriov_vf_init_late(struct xe_device *xe)
>  {
> +	if (!vf_migration_init_late(xe))
> +		return 0;
> +
>  	return xe_sriov_vf_ccs_init(xe);
>  }
>