Re: [PATCH] drm/i915/psr: ASYNC_VIDEO_TIMING_NOT_SUPPORTED_IN_PR not valid for eDP

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Thu, 2026-10-08 at 23:47 -0400, Jake Steinman wrote:
> Hi Jouni,
> 
> Tested on the XPS 16 DA16260 (PTL, xe, 7.3-rc5, DA16260 PR quirk
> removed, no other changes): Panel Replay SU is smooth with this
> patch.
> 
> Tested-by: Jake Steinman <j@metarealtyinc.ca>
> 
> Two things it leaves:
> 
> - The panel still judders for a few seconds after panel power-on
>   (DPMS on). Holding PR inactive after power-on fixes that here; 8 s
>   is clean, 3 s is not quite enough.
> 
> - No DC5 on a static screen while PR is active: 0 entries against 550
>   on a static VT with the AS SDP suspended.
> 
> Since this panel needs a specific change for the first one anyway,
> could the AS SDP also be suspended while vblank is disabled on panels
> that handle it, as in the RFC? That keeps DC5/DC6 on a static screen.
> https://lore.kernel.org/r/20261006220500.3417572-1-j@metarealtyinc.ca

I don't really see why we should bind it to vblank. I think vblank is
also disabled most of the times anyways where we could benefit from
having AS SDP disabled.
> 
> If you respin, a Reported-by would be appreciated.

Of course. I already added it, but my checkpatch complained about
missing Closes tag. I wasn't sure if this patch is closing any gitlab
ticket. I was thinking adding them both when tested.

I still need to modify also the commit message and consider even using
the change. eDP spec is saying that AS SDP can be disabled:

"The Source device may disable the Adaptive-Sync SDP transmission by
setting its Adaptive Sync SDP Transmission Disable in PR Active State
bit (DB0[2] = 1) in the Adaptive-Sync SDP. DPCD 00107h[6] shall remain
set (DPCD 00107h[6] = 1)."

Even if "crtc_state->disable_as_sdp_when_pr_active == 1" it should be
ok to disable AS SDP sending (referring you RFC patch). I'll guess
having inverse logic in ASYNC_VIDEO_TIMING_NOT_SUPPORTED_IN_PR means
eDP sink should always support it.


BR,
Jouni Högander

> 
> Thanks,
> Jake