Re: [PATCH] drm/xe: allow unaligned start and size xe_res_cursor parameters

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Fri, 2024-05-24 at 16:26 +0200, Andrzej Hajda wrote:
> On 18.04.2024 16:03, Andrzej Hajda wrote:
> > xe_res_cursor code does not depend on the alignment. On the other
> > side
> > unaligned accesses are useful from pread/pwrite point of view.
> > 
> > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> 
> Gently ping.

I think these asserts are aimed at catching weird
values from the page-table code.

But agree that the res_cursor code works without them AFAICT.
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> 
> Regards
> Andrzej
> 
> > ---
> >   drivers/gpu/drm/xe/xe_res_cursor.h | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_res_cursor.h
> > b/drivers/gpu/drm/xe/xe_res_cursor.h
> > index 0a306963aa8e..655af89b31a9 100644
> > --- a/drivers/gpu/drm/xe/xe_res_cursor.h
> > +++ b/drivers/gpu/drm/xe/xe_res_cursor.h
> > @@ -157,8 +157,6 @@ static inline void xe_res_first_sg(const struct
> > sg_table *sg,
> >   				   struct xe_res_cursor *cur)
> >   {
> >   	XE_WARN_ON(!sg);
> > -	XE_WARN_ON(!IS_ALIGNED(start, PAGE_SIZE) ||
> > -		   !IS_ALIGNED(size, PAGE_SIZE));
> >   	cur->node = NULL;
> >   	cur->start = start;
> >   	cur->remaining = size;
> > 
> > ---
> > base-commit: f9116f658a6217b101e3b4e89f845775b6fb05d9
> > change-id: 20240418-xe_res_cursor-no-align-a3bd26482244
> > 
> > Best regards,
>