Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Kuoppala, Mika" <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/xe: allow unaligned start and size xe_res_cursor parameters
Date: Fri, 24 May 2024 16:26:44 +0200	[thread overview]
Message-ID: <fa111202-bd70-4ec2-bdb5-ac11786693f6@intel.com> (raw)
In-Reply-To: <20240418-xe_res_cursor-no-align-v1-1-8df7834266c9@intel.com>

On 18.04.2024 16:03, Andrzej Hajda wrote:
> xe_res_cursor code does not depend on the alignment. On the other side
> unaligned accesses are useful from pread/pwrite point of view.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Gently ping.

Regards
Andrzej

> ---
>   drivers/gpu/drm/xe/xe_res_cursor.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_res_cursor.h b/drivers/gpu/drm/xe/xe_res_cursor.h
> index 0a306963aa8e..655af89b31a9 100644
> --- a/drivers/gpu/drm/xe/xe_res_cursor.h
> +++ b/drivers/gpu/drm/xe/xe_res_cursor.h
> @@ -157,8 +157,6 @@ static inline void xe_res_first_sg(const struct sg_table *sg,
>   				   struct xe_res_cursor *cur)
>   {
>   	XE_WARN_ON(!sg);
> -	XE_WARN_ON(!IS_ALIGNED(start, PAGE_SIZE) ||
> -		   !IS_ALIGNED(size, PAGE_SIZE));
>   	cur->node = NULL;
>   	cur->start = start;
>   	cur->remaining = size;
> 
> ---
> base-commit: f9116f658a6217b101e3b4e89f845775b6fb05d9
> change-id: 20240418-xe_res_cursor-no-align-a3bd26482244
> 
> Best regards,


  parent reply	other threads:[~2024-05-24 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 14:03 [PATCH] drm/xe: allow unaligned start and size xe_res_cursor parameters Andrzej Hajda
2024-04-18 14:15 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-18 14:15 ` ✓ CI.checkpatch: " Patchwork
2024-04-18 14:17 ` ✓ CI.KUnit: " Patchwork
2024-04-18 14:29 ` ✓ CI.Build: " Patchwork
2024-04-18 14:31 ` ✓ CI.Hooks: " Patchwork
2024-04-18 14:34 ` ✓ CI.checksparse: " Patchwork
2024-04-18 15:21 ` ✓ CI.BAT: " Patchwork
2024-04-20  2:58 ` ✓ CI.FULL: " Patchwork
2024-05-24 14:26 ` Andrzej Hajda [this message]
2024-05-24 14:46   ` [PATCH] " Thomas Hellström
2024-05-28 12:58     ` Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa111202-bd70-4ec2-bdb5-ac11786693f6@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=mika.kuoppala@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox