Re: [PATCH 3/5] drm/xe/tests/pci: Ensure all platforms have a valid GT/tile count

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 13.06.2025 02:14, Matt Roper wrote:
> Add a simple kunit test to ensure each platform's GT per tile count is
> non-zero and does not exceed the global XE_MAX_GT_PER_TILE definition.
> 
> We need to move 'struct xe_subplatform_desc' from the .c file to the
> types header to ensure it is accessible from the kunit test.
> 

...

> diff --git a/drivers/gpu/drm/xe/tests/xe_pci_test.h b/drivers/gpu/drm/xe/tests/xe_pci_test.h
> index ede46800aff1..5abbf522f7a8 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci_test.h
> +++ b/drivers/gpu/drm/xe/tests/xe_pci_test.h
> @@ -14,13 +14,16 @@
>  struct xe_device;
>  struct xe_graphics_desc;
>  struct xe_media_desc;
> +struct xe_device_desc;
>  
>  typedef int (*xe_device_fn)(struct xe_device *);

note: this is not used, can be dropped/replaced

>  typedef void (*xe_graphics_fn)(const struct xe_graphics_desc *);
>  typedef void (*xe_media_fn)(const struct xe_media_desc *);
> +typedef void (*xe_platform_fn)(const struct xe_device_desc *);

this is more like 'device_desc' function, so either:

	xe_device_desc_fn
or
	xe_device_fn

since previous typedef is not used anywhere

>  
>  void xe_call_for_each_graphics_ip(xe_graphics_fn xe_fn);
>  void xe_call_for_each_media_ip(xe_media_fn xe_fn);
> +void xe_call_for_each_platform(xe_platform_fn xe_fn);

to match above pattern maybe:

	void xe_call_for_each_device_desc(xe_device_desc_fn fn);

then later we could add really something like:

	typedef void (*xe_platform_fn)(enum xe_platform platform,
				       enum xe_subplatform subplatform);

	void xe_call_for_each_platform(xe_platform_fn xe_fn);

which would help us create new tests based on per-platform pattern.

or maybe we should already start converting existing tests that use
xe_call_for_each() into parametrized tests that use generators instead?