Re: [PATCH v4 2/2] drm/xe/guc: Update GuC log buffer type value

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/2/2025 5:03 PM, Zhanjun Dong wrote:
> Update GuC log buffer type value, to align with the GuC specification.
> Rename GUC_LOG_BUFFER_DEBUG to GUC_LOG_BUFFER_EVENT_LOG.

hmm, my copy of GuC specification has:

	GENERAL = 0	/* Log event data */
	CRASH = 1	/* Raw crash data */ 
	ERROR_STATE_CAPTURE = 2	/* Error State Capture data */

so if the goal is to align (more) with the spec, maybe it should be (to keep them reasonable short):

	GENERAL_LOG
	CRASH_DUMP
	ERROR_CAPTURE

+ @Daniele

and btw, IMO this patch should be before the other one that cleanups macros

> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
>  drivers/gpu/drm/xe/abi/guc_log_abi.h | 2 +-
>  drivers/gpu/drm/xe/xe_guc_log.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/abi/guc_log_abi.h b/drivers/gpu/drm/xe/abi/guc_log_abi.h
> index 554630b7ccd9..1a487164b980 100644
> --- a/drivers/gpu/drm/xe/abi/guc_log_abi.h
> +++ b/drivers/gpu/drm/xe/abi/guc_log_abi.h
> @@ -10,8 +10,8 @@
>  
>  /* GuC logging buffer types */
>  enum guc_log_buffer_type {
> +	GUC_LOG_BUFFER_EVENT_LOG,
>  	GUC_LOG_BUFFER_CRASH_DUMP,
> -	GUC_LOG_BUFFER_DEBUG,
>  	GUC_LOG_BUFFER_CAPTURE,
>  };

>  
> diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
> index fa1d490dca0d..900b39fc734f 100644
> --- a/drivers/gpu/drm/xe/xe_guc_log.c
> +++ b/drivers/gpu/drm/xe/xe_guc_log.c
> @@ -293,7 +293,7 @@ u32 xe_guc_get_log_buffer_offset(struct xe_guc_log *log, enum guc_log_buffer_typ
>  	case GUC_LOG_BUFFER_CRASH_DUMP:
>  		offset += XE_GUC_LOG_EVENT_LOG_BUFFER_SIZE;
>  		fallthrough;
> -	case GUC_LOG_BUFFER_DEBUG:
> +	case GUC_LOG_BUFFER_EVENT_LOG:
>  		break;
>  	}
>