Re: [PATCH v4 2/2] drm/xe/guc: Update GuC log buffer type value

["Dong, Zhanjun" <zhanjun.dong@intel.com>]

On 2025-10-04 12:42 p.m., Michal Wajdeczko wrote:
> 
> 
> On 10/2/2025 5:03 PM, Zhanjun Dong wrote:
>> Update GuC log buffer type value, to align with the GuC specification.
>> Rename GUC_LOG_BUFFER_DEBUG to GUC_LOG_BUFFER_EVENT_LOG.
> 
> hmm, my copy of GuC specification has:
> 
> 	GENERAL = 0	/* Log event data */
> 	CRASH = 1	/* Raw crash data */
> 	ERROR_STATE_CAPTURE = 2	/* Error State Capture data */
> 
> so if the goal is to align (more) with the spec, maybe it should be (to keep them reasonable short):
> 
> 	GENERAL_LOG

1st, the issue is the "GENERAL" here give us no information about what 
it is,
GENERAL_LOG almost equal to _LOG.
2nd, here is within the enum define about log buffer type, so _LOG here 
also didn't tell us anything.

As you mentioned:
   GENERAL = 0	/* Log event data */
that's why I would like to use the name from comment

EVENT_LOG
This name tell us something and also aligned with spec.
or maybe
EVENT
as _LOG means nothing here
BTW, the previous name _DEBUG not aligns with spec, too generic and not 
provide much info.

> 	CRASH_DUMP
> 	ERROR_CAPTURE
That's fine

Regards,
Zhanjun Dong

> 
> + @Daniele
> 
> and btw, IMO this patch should be before the other one that cleanups macros
> 
>>
>> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
>> ---
>>   drivers/gpu/drm/xe/abi/guc_log_abi.h | 2 +-
>>   drivers/gpu/drm/xe/xe_guc_log.c      | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/abi/guc_log_abi.h b/drivers/gpu/drm/xe/abi/guc_log_abi.h
>> index 554630b7ccd9..1a487164b980 100644
>> --- a/drivers/gpu/drm/xe/abi/guc_log_abi.h
>> +++ b/drivers/gpu/drm/xe/abi/guc_log_abi.h
>> @@ -10,8 +10,8 @@
>>   
>>   /* GuC logging buffer types */
>>   enum guc_log_buffer_type {
>> +	GUC_LOG_BUFFER_EVENT_LOG,
>>   	GUC_LOG_BUFFER_CRASH_DUMP,
>> -	GUC_LOG_BUFFER_DEBUG,
>>   	GUC_LOG_BUFFER_CAPTURE,
>>   };
> 
>>   
>> diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
>> index fa1d490dca0d..900b39fc734f 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_log.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_log.c
>> @@ -293,7 +293,7 @@ u32 xe_guc_get_log_buffer_offset(struct xe_guc_log *log, enum guc_log_buffer_typ
>>   	case GUC_LOG_BUFFER_CRASH_DUMP:
>>   		offset += XE_GUC_LOG_EVENT_LOG_BUFFER_SIZE;
>>   		fallthrough;
>> -	case GUC_LOG_BUFFER_DEBUG:
>> +	case GUC_LOG_BUFFER_EVENT_LOG:
>>   		break;
>>   	}
>>   
>