Re: [Intel-xe] [PATCH] drm/xe: Fix kernel doc warning for PMU events

[Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>]

On 19/09/23 13:16, Thomas Hellström wrote:
> +Lucas for any --fixup comments.
>
> Hi, Aravind.
>
> On 9/19/23 08:36, Aravind Iddamsetty wrote:
>> Add DOC keyword to PMU events comment in include/drm/xe_drm.h to make it
>> kernel doc format.
>>
>> Fixes: 4a9681392cec ("drm/xe/pmu: Enable PMU interface")
>
> Since we're still rebasing xe, The above commit hash will soon be stale, so  I think the proper way to add this is to do
>
> git commit --fixup=<commit hash>

Hi Thomas,

Thanks for your comment.

Ashutosh had suggested the same, so I had modified and merged the change.

Thanks,
Aravind.


>
>
>>
>> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>
>> ---
>>   include/uapi/drm/xe_drm.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
>> index 63863eda8355..6ab85c7fed36 100644
>> --- a/include/uapi/drm/xe_drm.h
>> +++ b/include/uapi/drm/xe_drm.h
>> @@ -1054,7 +1054,7 @@ struct drm_xe_vm_madvise {
>>   };
>>     /**
>> - * XE PMU event config IDs
>> + * DOC: XE PMU event config IDs
>>    *
>>    * Check 'man perf_event_open' to use these ID's in 'struct perf_event_attr'
>>    * as part of perf_event_open syscall to read a particular event.
>
> Otherwise LGTM.
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
>