Re: [PATCH v3 1/1] drm/xe/xe2: Introduce performance changes

["Chauhan, Shekhar" <shekhar.chauhan@intel.com>]

On 8/2/2024 19:42, Akshata Jahagirdar wrote:
> Add Compression Performance Improvement Changes in Xe2
>
> v2: Rebase
>
> v3: Rebase, updated as per latest changes on bspec,
>      Removed unnecessary default actions (Matt)
>      formatting nits (Tejas)
>
> v4: Formatting nits, removed default set action for bit 14 (Matt)
>
> Bspec: 72161
> Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_gt_regs.h | 3 +++
>   drivers/gpu/drm/xe/xe_tuning.c       | 5 +++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> index 3b87f95f9ecf..c50643ab4c84 100644
> --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> @@ -367,6 +367,9 @@
>   #define XEHP_L3NODEARBCFG			XE_REG_MCR(0xb0b4)
>   #define   XEHP_LNESPARE				REG_BIT(19)
>   
> +#define L3SQCREG2				XE_REG_MCR(0xb104)
> +#define   COMPMEMRD256BOVRFETCHEN		REG_BIT(20)
> +
>   #define L3SQCREG3				XE_REG_MCR(0xb108)
>   #define   COMPPWOVERFETCHEN			REG_BIT(28)
>   
> diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
> index 77d4eec0118d..3817b7743b0c 100644
> --- a/drivers/gpu/drm/xe/xe_tuning.c
> +++ b/drivers/gpu/drm/xe/xe_tuning.c
> @@ -45,6 +45,11 @@ static const struct xe_rtp_entry_sr gt_tunings[] = {
>   	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, XE_RTP_END_VERSION_UNDEFINED)),
>   	  XE_RTP_ACTIONS(SET(L3SQCREG3, COMPPWOVERFETCHEN))
>   	},
> +	{ XE_RTP_NAME("Tuning: L2 Overfetch Compressible Only"),
> +	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, XE_RTP_END_VERSION_UNDEFINED)),
> +	  XE_RTP_ACTIONS(SET(L3SQCREG2,
> +			     COMPMEMRD256BOVRFETCHEN))
Can we merge this into the same line, or any particular reason for 
adding a line break?
> +	},
>   	{}
>   };
>   

-- 
-shekhar