Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, imre.deak@intel.com
Subject: [PATCH 2/6] drm/i915/dp: change the order of intel_dp_mtp_tu_compute_config() params
Date: Wed, 29 Jan 2025 16:46:34 +0200	[thread overview]
Message-ID: <ea9669edc5973cdbca92aeb4e168850015e9d1bb.1738161945.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1738161945.git.jani.nikula@intel.com>

Pointers first, bpp params in min, max, step. This is slightly more
natural to follow.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c     | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 8 +++-----
 drivers/gpu/drm/i915/display/intel_dp_mst.h | 3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d367f9c2fa23..c387de69d55e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2643,9 +2643,9 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
 		if (!ret && intel_dp_is_uhbr(pipe_config))
 			ret = intel_dp_mtp_tu_compute_config(intel_dp,
 							     pipe_config,
+							     conn_state,
 							     pipe_config->pipe_bpp,
 							     pipe_config->pipe_bpp,
-							     conn_state,
 							     0, false);
 		if (ret)
 			dsc_needed = true;
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 2acc26aad6a0..98d7cdddfead 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -211,9 +211,8 @@ static int intel_dp_mst_dsc_get_slice_count(const struct intel_connector *connec
 
 int intel_dp_mtp_tu_compute_config(struct intel_dp *intel_dp,
 				   struct intel_crtc_state *crtc_state,
-				   int max_bpp, int min_bpp,
 				   struct drm_connector_state *conn_state,
-				   int step, bool dsc)
+				   int min_bpp, int max_bpp, int step, bool dsc)
 {
 	struct intel_display *display = to_intel_display(intel_dp);
 	struct drm_atomic_state *state = crtc_state->uapi.state;
@@ -380,9 +379,8 @@ static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
 	mst_state->pbn_div = drm_dp_get_vc_payload_bw(crtc_state->port_clock,
 						      crtc_state->lane_count);
 
-	return intel_dp_mtp_tu_compute_config(intel_dp, crtc_state,
-					      max_bpp, min_bpp,
-					      conn_state, step, dsc);
+	return intel_dp_mtp_tu_compute_config(intel_dp, crtc_state, conn_state,
+					      min_bpp, max_bpp, step, dsc);
 }
 
 static int mst_stream_compute_link_config(struct intel_dp *intel_dp,
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.h b/drivers/gpu/drm/i915/display/intel_dp_mst.h
index c6bdc1d190a4..a713a1c10154 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.h
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.h
@@ -33,8 +33,7 @@ bool intel_dp_mst_verify_dpcd_state(struct intel_dp *intel_dp);
 
 int intel_dp_mtp_tu_compute_config(struct intel_dp *intel_dp,
 				   struct intel_crtc_state *crtc_state,
-				   int max_bpp, int min_bpp,
 				   struct drm_connector_state *conn_state,
-				   int step, bool dsc);
+				   int min_bpp, int max_bpp, int step, bool dsc);
 
 #endif /* __INTEL_DP_MST_H__ */
-- 
2.39.5


  parent reply	other threads:[~2025-01-29 14:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 14:46 [PATCH 0/6] drm/i915: DP and DP MST cleanups Jani Nikula
2025-01-29 14:46 ` [PATCH 1/6] drm/i915/dp: constify struct link_config_limits pointers Jani Nikula
2025-01-30 13:47   ` Imre Deak
2025-01-29 14:46 ` Jani Nikula [this message]
2025-01-30 14:03   ` [PATCH 2/6] drm/i915/dp: change the order of intel_dp_mtp_tu_compute_config() params Imre Deak
2025-01-29 14:46 ` [PATCH 3/6] drm/i915/mst: change where lane_count and port_clock are set Jani Nikula
2025-01-30 14:16   ` Imre Deak
2025-01-29 14:46 ` [PATCH 4/6] drm/i915/mst: handle mst pbn_div in intel_dp_mtp_tu_compute_config() Jani Nikula
2025-01-30 14:23   ` Imre Deak
2025-01-30 21:14     ` Jani Nikula
2025-01-30 21:34       ` Imre Deak
2025-01-29 14:46 ` [PATCH 5/6] drm/i915/mst: remove unnecessary mst_stream_find_vcpi_slots_for_bpp() Jani Nikula
2025-01-30 14:25   ` Imre Deak
2025-01-29 14:46 ` [PATCH 6/6] drm/i915/mst: use min_array() and max_array() instead of hand-rolling Jani Nikula
2025-01-30 14:35   ` Imre Deak
2025-01-30 14:39     ` Imre Deak
2025-01-31  9:20       ` Jani Nikula
2025-01-31  9:38         ` Raag Jadav
2025-01-29 16:31 ` ✓ CI.Patch_applied: success for series starting with [1/6] drm/i915/dp: constify struct link_config_limits pointers Patchwork
2025-01-29 16:32 ` ✓ CI.checkpatch: " Patchwork
2025-01-29 16:33 ` ✓ CI.KUnit: " Patchwork
2025-01-29 16:49 ` ✓ CI.Build: success for drm/i915: DP and DP MST cleanups Patchwork
2025-01-29 16:51 ` ✗ CI.Hooks: failure " Patchwork
2025-01-29 16:53 ` ✗ CI.checksparse: warning " Patchwork
2025-01-29 17:13 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-30  0:24 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea9669edc5973cdbca92aeb4e168850015e9d1bb.1738161945.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox