From: Matthew Auld <matthew.auld@intel.com>
To: Nitin Gote <nitin.r.gote@intel.com>, intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: Re: [PATCH] drm/xe: derive mem copy capability from graphics version
Date: Mon, 19 Jan 2026 15:19:26 +0000 [thread overview]
Message-ID: <eaf959db-5ab7-40e3-904b-58a37291b0f1@intel.com> (raw)
In-Reply-To: <20260119150304.1739757-2-nitin.r.gote@intel.com>
On 19/01/2026 15:03, Nitin Gote wrote:
> Drop .has_mem_copy_instr from the platform descriptors and compute
> it in xe_info_init() once handle_gmdid() populates graphics_verx100.
> Early init was running with graphics_verx100==0, so the old placement
> silently disabled MEM_COPY on every GMDID platform. Centralizing the
Nit: IMO the wording is odd here, it makes it sound like the old
behaviour was to check GMDID in early init which ofc doesn't work. But
it never it did that. Maybe just drop that entire sentence?
> GRAPHICS_VER(xe) >= 20 check keeps Xe2+ enabled and removes redundant
> per-platform plumbing for future Xe platforms.
>
> Bspec: 57561
>
> Fixes: 1e12dbae9d72 ("drm/xe/migrate: support MEM_COPY instruction")
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2026-01-19 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 15:03 [PATCH] drm/xe: derive mem copy capability from graphics version Nitin Gote
2026-01-19 14:37 ` ✗ CI.KUnit: failure for drm/xe: derive mem copy capability from graphics version (rev2) Patchwork
2026-01-19 15:19 ` Matthew Auld [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-20 5:47 [PATCH] drm/xe: derive mem copy capability from graphics version Nitin Gote
2026-01-19 12:18 Nitin Gote
2026-01-19 13:17 ` Matthew Auld
2026-01-19 14:24 ` Gote, Nitin R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf959db-5ab7-40e3-904b-58a37291b0f1@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=nitin.r.gote@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox