Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Add warn when level can not be zero.
@ 2024-05-21 10:36 Nirmoy Das
  2024-05-21 10:58 ` Matthew Auld
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Nirmoy Das @ 2024-05-21 10:36 UTC (permalink / raw)
  To: intel-xe; +Cc: Nirmoy Das, Matthew Auld

At xe_pt_zap_ptes_entry() and xe_pt_stage_unbind_entry, the level cannot
be 0. Therefore, add an independent check for the level. Since the level
cannot be zero at this point, there is no need to check for `is_compact`,
so remove that instead.

Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_pt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 11dd0988ffda..cd60c009b679 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -763,7 +763,7 @@ static int xe_pt_zap_ptes_entry(struct xe_ptw *parent, pgoff_t offset,
 	pgoff_t end_offset;
 
 	XE_WARN_ON(!*child);
-	XE_WARN_ON(!level && xe_child->is_compact);
+	XE_WARN_ON(!level);
 
 	/*
 	 * Note that we're called from an entry callback, and we're dealing
@@ -1445,7 +1445,7 @@ static int xe_pt_stage_unbind_entry(struct xe_ptw *parent, pgoff_t offset,
 	struct xe_pt *xe_child = container_of(*child, typeof(*xe_child), base);
 
 	XE_WARN_ON(!*child);
-	XE_WARN_ON(!level && xe_child->is_compact);
+	XE_WARN_ON(!level);
 
 	xe_pt_check_kill(addr, next, level - 1, xe_child, action, walk);
 
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-05-21 20:14 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 10:36 [PATCH] drm/xe: Add warn when level can not be zero Nirmoy Das
2024-05-21 10:58 ` Matthew Auld
2024-05-21 12:27 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-21 12:27 ` ✓ CI.checkpatch: " Patchwork
2024-05-21 12:28 ` ✓ CI.KUnit: " Patchwork
2024-05-21 12:42 ` ✓ CI.Build: " Patchwork
2024-05-21 12:45 ` ✓ CI.Hooks: " Patchwork
2024-05-21 12:48 ` ✓ CI.checksparse: " Patchwork
2024-05-21 13:09 ` ✓ CI.BAT: " Patchwork
2024-05-21 14:08 ` [PATCH] " Matthew Brost
2024-05-21 14:52   ` Matthew Auld
2024-05-21 15:32     ` Matthew Brost
2024-05-21 20:14       ` Nirmoy Das
2024-05-21 16:08 ` ✗ CI.FULL: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox