Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Fix xe_force_wake_assert_held for enum XE_FORCEWAKE_ALL
@ 2024-05-30 14:25 Himal Prasad Ghimiray
  2024-05-30 14:21 ` Nilawar, Badal
                   ` (8 more replies)
  0 siblings, 9 replies; 19+ messages in thread
From: Himal Prasad Ghimiray @ 2024-05-30 14:25 UTC (permalink / raw)
  To: intel-xe; +Cc: Himal Prasad Ghimiray, Rodrigo Vivi, Badal Nilawar

Make sure that the assertion condition covers the wakefulness of all
domains for XE_FORCEWAKE_ALL.

Fixes: c73acc1eeba5 ("drm/xe: Use Xe assert macros instead of XE_WARN_ON macro")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
 drivers/gpu/drm/xe/xe_force_wake.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_force_wake.h b/drivers/gpu/drm/xe/xe_force_wake.h
index 83cb157da7cc..9008928b187f 100644
--- a/drivers/gpu/drm/xe/xe_force_wake.h
+++ b/drivers/gpu/drm/xe/xe_force_wake.h
@@ -32,7 +32,7 @@ static inline void
 xe_force_wake_assert_held(struct xe_force_wake *fw,
 			  enum xe_force_wake_domains domain)
 {
-	xe_gt_assert(fw->gt, fw->awake_domains & domain);
+	xe_gt_assert(fw->gt, (fw->awake_domains & domain) == domain);
 }
 
 #endif
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2024-06-06  6:08 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 14:25 [PATCH] drm/xe: Fix xe_force_wake_assert_held for enum XE_FORCEWAKE_ALL Himal Prasad Ghimiray
2024-05-30 14:21 ` Nilawar, Badal
2024-05-30 14:44   ` Nilawar, Badal
2024-05-30 16:39     ` Ghimiray, Himal Prasad
2024-06-03 21:03       ` Matt Roper
2024-06-04 10:52         ` Nilawar, Badal
2024-06-05 21:09           ` Matt Roper
2024-06-06  4:34             ` Ghimiray, Himal Prasad
2024-06-06  5:19               ` Lucas De Marchi
2024-06-06  5:30               ` Riana Tauro
2024-06-06  6:08                 ` Ghimiray, Himal Prasad
2024-05-30 14:59 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-30 15:00 ` ✓ CI.checkpatch: " Patchwork
2024-05-30 15:01 ` ✓ CI.KUnit: " Patchwork
2024-05-30 15:12 ` ✓ CI.Build: " Patchwork
2024-05-30 15:13 ` ✗ CI.Hooks: failure " Patchwork
2024-05-30 15:14 ` ✓ CI.checksparse: success " Patchwork
2024-05-30 15:49 ` ✗ CI.BAT: failure " Patchwork
2024-05-30 18:23 ` ✗ CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox