* ✗ CI.KUnit: failure for drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64
2025-06-13 6:12 [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64 Ankit Nautiyal
@ 2025-06-13 7:59 ` Patchwork
2025-06-13 9:21 ` [PATCH] " Kandpal, Suraj
2025-06-13 9:36 ` Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2025-06-13 7:59 UTC (permalink / raw)
To: Ankit Nautiyal; +Cc: intel-xe
== Series Details ==
Series: drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64
URL : https://patchwork.freedesktop.org/series/150202/
State : failure
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[07:57:44] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[07:57:51] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[07:58:45] Starting KUnit Kernel (1/1)...
[07:58:45] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[07:58:45] ================== guc_buf (11 subtests) ===================
[07:58:45] [PASSED] test_smallest
[07:58:45] [PASSED] test_largest
[07:58:45] [PASSED] test_granular
[07:58:45] [PASSED] test_unique
[07:58:45] [PASSED] test_overlap
[07:58:45] [PASSED] test_reusable
[07:58:45] [PASSED] test_too_big
[07:58:45] [PASSED] test_flush
[07:58:45] [PASSED] test_lookup
[07:58:45] [PASSED] test_data
[07:58:45] [PASSED] test_class
[07:58:45] ===================== [PASSED] guc_buf =====================
[07:58:45] =================== guc_dbm (7 subtests) ===================
[07:58:45] [PASSED] test_empty
[07:58:45] [PASSED] test_default
[07:58:45] ======================== test_size ========================
[07:58:45] [PASSED] 4
[07:58:45] [PASSED] 8
[07:58:45] [PASSED] 32
[07:58:45] [PASSED] 256
[07:58:45] ==================== [PASSED] test_size ====================
[07:58:45] ======================= test_reuse ========================
[07:58:45] [PASSED] 4
[07:58:45] [PASSED] 8
[07:58:45] [PASSED] 32
[07:58:45] [PASSED] 256
[07:58:45] =================== [PASSED] test_reuse ====================
[07:58:45] =================== test_range_overlap ====================
[07:58:45] [PASSED] 4
[07:58:45] [PASSED] 8
[07:58:45] [PASSED] 32
[07:58:45] [PASSED] 256
[07:58:45] =============== [PASSED] test_range_overlap ================
[07:58:45] =================== test_range_compact ====================
[07:58:45] [PASSED] 4
[07:58:45] [PASSED] 8
[07:58:45] [PASSED] 32
[07:58:45] [PASSED] 256
[07:58:45] =============== [PASSED] test_range_compact ================
[07:58:45] ==================== test_range_spare =====================
[07:58:45] [PASSED] 4
[07:58:45] [PASSED] 8
[07:58:45] [PASSED] 32
[07:58:45] [PASSED] 256
[07:58:45] ================ [PASSED] test_range_spare =================
[07:58:45] ===================== [PASSED] guc_dbm =====================
[07:58:45] =================== guc_idm (6 subtests) ===================
[07:58:45] [PASSED] bad_init
[07:58:45] [PASSED] no_init
[07:58:45] [PASSED] init_fini
[07:58:45] [PASSED] check_used
[07:58:45] [PASSED] check_quota
[07:58:45] [PASSED] check_all
[07:58:45] ===================== [PASSED] guc_idm =====================
[07:58:45] ================== no_relay (3 subtests) ===================
[07:58:45] [PASSED] xe_drops_guc2pf_if_not_ready
[07:58:45] [PASSED] xe_drops_guc2vf_if_not_ready
[07:58:45] [PASSED] xe_rejects_send_if_not_ready
[07:58:45] ==================== [PASSED] no_relay =====================
[07:58:45] ================== pf_relay (14 subtests) ==================
[07:58:45] [PASSED] pf_rejects_guc2pf_too_short
[07:58:45] [PASSED] pf_rejects_guc2pf_too_long
[07:58:45] [PASSED] pf_rejects_guc2pf_no_payload
[07:58:45] [PASSED] pf_fails_no_payload
[07:58:45] [PASSED] pf_fails_bad_origin
[07:58:45] [PASSED] pf_fails_bad_type
[07:58:45] [PASSED] pf_txn_reports_error
[07:58:45] [PASSED] pf_txn_sends_pf2guc
[07:58:45] [PASSED] pf_sends_pf2guc
[07:58:45] [SKIPPED] pf_loopback_nop
[07:58:45] [SKIPPED] pf_loopback_echo
[07:58:45] [SKIPPED] pf_loopback_fail
[07:58:45] [SKIPPED] pf_loopback_busy
[07:58:45] [SKIPPED] pf_loopback_retry
[07:58:45] ==================== [PASSED] pf_relay =====================
[07:58:45] ================== vf_relay (3 subtests) ===================
[07:58:45] [PASSED] vf_rejects_guc2vf_too_short
[07:58:45] [PASSED] vf_rejects_guc2vf_too_long
[07:58:45] [PASSED] vf_rejects_guc2vf_no_payload
[07:58:45] ==================== [PASSED] vf_relay =====================
[07:58:45] ================= pf_service (11 subtests) =================
[07:58:45] [PASSED] pf_negotiate_any
[07:58:45] [PASSED] pf_negotiate_base_match
[07:58:45] [PASSED] pf_negotiate_base_newer
[07:58:45] [PASSED] pf_negotiate_base_next
[07:58:45] [SKIPPED] pf_negotiate_base_older
[07:58:45] [PASSED] pf_negotiate_base_prev
[07:58:45] [PASSED] pf_negotiate_latest_match
[07:58:45] [PASSED] pf_negotiate_latest_newer
[07:58:45] [PASSED] pf_negotiate_latest_next
[07:58:45] [SKIPPED] pf_negotiate_latest_older
[07:58:45] [SKIPPED] pf_negotiate_latest_prev
[07:58:45] =================== [PASSED] pf_service ====================
[07:58:45] ===================== lmtt (1 subtest) =====================
[07:58:45] ======================== test_ops =========================
[07:58:45] [PASSED] 2-level
[07:58:45] [PASSED] multi-level
[07:58:45] ==================== [PASSED] test_ops =====================
[07:58:45] ====================== [PASSED] lmtt =======================
[07:58:45] =================== xe_mocs (2 subtests) ===================
[07:58:45] ================ xe_live_mocs_kernel_kunit ================
[07:58:45] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[07:58:45] ================ xe_live_mocs_reset_kunit =================
[07:58:45] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[07:58:45] ==================== [SKIPPED] xe_mocs =====================
[07:58:45] ================= xe_migrate (2 subtests) ==================
[07:58:45] ================= xe_migrate_sanity_kunit =================
[07:58:45] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[07:58:45] ================== xe_validate_ccs_kunit ==================
[07:58:45] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[07:58:45] =================== [SKIPPED] xe_migrate ===================
[07:58:45] ================== xe_dma_buf (1 subtest) ==================
[07:58:45] ==================== xe_dma_buf_kunit =====================
[07:58:45] ================ [SKIPPED] xe_dma_buf_kunit ================
[07:58:45] =================== [SKIPPED] xe_dma_buf ===================
[07:58:45] ================= xe_bo_shrink (1 subtest) =================
[07:58:45] =================== xe_bo_shrink_kunit ====================
[07:58:45] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[07:58:45] ================== [SKIPPED] xe_bo_shrink ==================
[07:58:45] ==================== xe_bo (2 subtests) ====================
[07:58:45] ================== xe_ccs_migrate_kunit ===================
[07:58:45] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[07:58:45] ==================== xe_bo_evict_kunit ====================
[07:58:45] =============== [SKIPPED] xe_bo_evict_kunit ================
[07:58:45] ===================== [SKIPPED] xe_bo ======================
[07:58:45] ==================== args (11 subtests) ====================
[07:58:45] [PASSED] count_args_test
[07:58:45] [PASSED] call_args_example
[07:58:45] [PASSED] call_args_test
[07:58:45] [PASSED] drop_first_arg_example
[07:58:45] [PASSED] drop_first_arg_test
[07:58:45] [PASSED] first_arg_example
[07:58:45] [PASSED] first_arg_test
[07:58:45] [PASSED] last_arg_example
[07:58:45] [PASSED] last_arg_test
[07:58:45] [PASSED] pick_arg_example
[07:58:45] [PASSED] sep_comma_example
[07:58:45] ====================== [PASSED] args =======================
[07:58:45] =================== xe_pci (2 subtests) ====================
[07:58:45] [PASSED] xe_gmdid_graphics_ip
[07:58:45] [PASSED] xe_gmdid_media_ip
[07:58:45] ===================== [PASSED] xe_pci ======================
[07:58:45] =================== xe_rtp (2 subtests) ====================
[07:58:45] =============== xe_rtp_process_to_sr_tests ================
[07:58:45] [PASSED] coalesce-same-reg
[07:58:45] [PASSED] no-match-no-add
[07:58:45] [PASSED] match-or
[07:58:45] [PASSED] match-or-xfail
[07:58:45] [PASSED] no-match-no-add-multiple-rules
[07:58:45] [PASSED] two-regs-two-entries
[07:58:45] [PASSED] clr-one-set-other
[07:58:45] [PASSED] set-field
[07:58:45] [PASSED] conflict-duplicate
[07:58:45] [PASSED] conflict-not-disjoint
stty: 'standard input': Inappropriate ioctl for device
[07:58:45] [PASSED] conflict-reg-type
[07:58:45] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[07:58:45] ================== xe_rtp_process_tests ===================
[07:58:45] [PASSED] active1
[07:58:45] [PASSED] active2
[07:58:45] [PASSED] active-inactive
[07:58:45] [PASSED] inactive-active
[07:58:45] [PASSED] inactive-1st_or_active-inactive
[07:58:45] [PASSED] inactive-2nd_or_active-inactive
[07:58:45] [PASSED] inactive-last_or_active-inactive
[07:58:45] [PASSED] inactive-no_or_active-inactive
[07:58:45] ============== [PASSED] xe_rtp_process_tests ===============
[07:58:45] ===================== [PASSED] xe_rtp ======================
[07:58:45] ==================== xe_wa (1 subtest) =====================
[07:58:45] ======================== xe_wa_gt =========================
[07:58:45] [PASSED] TIGERLAKE (B0)
[07:58:45] [PASSED] DG1 (A0)
[07:58:45] [PASSED] DG1 (B0)
[07:58:45] [PASSED] ALDERLAKE_S (A0)
[07:58:45] [PASSED] ALDERLAKE_S (B0)
[07:58:45] [PASSED] ALDERLAKE_S (C0)
[07:58:45] [PASSED] ALDERLAKE_S (D0)
[07:58:45] [PASSED] ALDERLAKE_P (A0)
[07:58:45] [PASSED] ALDERLAKE_P (B0)
[07:58:45] [PASSED] ALDERLAKE_P (C0)
[07:58:45] [PASSED] ALDERLAKE_S_RPLS (D0)
[07:58:45] [PASSED] ALDERLAKE_P_RPLU (E0)
[07:58:45] [PASSED] DG2_G10 (C0)
[07:58:45] [PASSED] DG2_G11 (B1)
[07:58:45] [PASSED] DG2_G12 (A1)
[07:58:45] [PASSED] METEORLAKE (g:A0, m:A0)
[07:58:45] [PASSED] METEORLAKE (g:A0, m:A0)
[07:58:45] [PASSED] METEORLAKE (g:A0, m:A0)
[07:58:45] [PASSED] LUNARLAKE (g:A0, m:A0)
[07:58:45] [PASSED] LUNARLAKE (g:B0, m:A0)
[07:58:45] [PASSED] BATTLEMAGE (g:A0, m:A1)
[07:58:45] ==================== [PASSED] xe_wa_gt =====================
[07:58:45] ====================== [PASSED] xe_wa ======================
[07:58:45] ============================================================
[07:58:45] Testing complete. Ran 133 tests: passed: 117, skipped: 16
[07:58:45] Elapsed time: 60.771s total, 6.885s configuring, 53.410s building, 0.426s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[07:58:45] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[07:58:48] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[07:59:30] Starting KUnit Kernel (1/1)...
[07:59:30] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[07:59:30] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[07:59:30] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[07:59:30] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[07:59:30] =========== drm_validate_clone_mode (2 subtests) ===========
[07:59:30] ============== drm_test_check_in_clone_mode ===============
[07:59:30] [PASSED] in_clone_mode
[07:59:30] [PASSED] not_in_clone_mode
[07:59:30] ========== [PASSED] drm_test_check_in_clone_mode ===========
[07:59:30] =============== drm_test_check_valid_clones ===============
[07:59:30] [PASSED] not_in_clone_mode
[07:59:30] [PASSED] valid_clone
[07:59:30] [PASSED] invalid_clone
[07:59:30] =========== [PASSED] drm_test_check_valid_clones ===========
[07:59:30] ============= [PASSED] drm_validate_clone_mode =============
[07:59:30] ============= drm_validate_modeset (1 subtest) =============
[07:59:30] [PASSED] drm_test_check_connector_changed_modeset
[07:59:30] ============== [PASSED] drm_validate_modeset ===============
[07:59:30] ====== drm_test_bridge_get_current_state (2 subtests) ======
[07:59:30] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[07:59:30] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[07:59:30] ======== [PASSED] drm_test_bridge_get_current_state ========
[07:59:30] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[07:59:30] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[07:59:30] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[07:59:30] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[07:59:30] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[07:59:30] ============== drm_bridge_alloc (2 subtests) ===============
[07:59:30] [PASSED] drm_test_drm_bridge_alloc_basic
[07:59:30] [PASSED] drm_test_drm_bridge_alloc_get_put
[07:59:30] ================ [PASSED] drm_bridge_alloc =================
[07:59:30] ================== drm_buddy (7 subtests) ==================
[07:59:30] [PASSED] drm_test_buddy_alloc_limit
[07:59:30] [PASSED] drm_test_buddy_alloc_optimistic
[07:59:30] [PASSED] drm_test_buddy_alloc_pessimistic
[07:59:30] [PASSED] drm_test_buddy_alloc_pathological
[07:59:30] [PASSED] drm_test_buddy_alloc_contiguous
[07:59:30] [PASSED] drm_test_buddy_alloc_clear
[07:59:30] [PASSED] drm_test_buddy_alloc_range_bias
[07:59:30] ==================== [PASSED] drm_buddy ====================
[07:59:30] ============= drm_cmdline_parser (40 subtests) =============
[07:59:30] [PASSED] drm_test_cmdline_force_d_only
[07:59:30] [PASSED] drm_test_cmdline_force_D_only_dvi
[07:59:30] [PASSED] drm_test_cmdline_force_D_only_hdmi
[07:59:30] [PASSED] drm_test_cmdline_force_D_only_not_digital
[07:59:30] [PASSED] drm_test_cmdline_force_e_only
[07:59:30] [PASSED] drm_test_cmdline_res
[07:59:30] [PASSED] drm_test_cmdline_res_vesa
[07:59:30] [PASSED] drm_test_cmdline_res_vesa_rblank
[07:59:30] [PASSED] drm_test_cmdline_res_rblank
[07:59:30] [PASSED] drm_test_cmdline_res_bpp
[07:59:30] [PASSED] drm_test_cmdline_res_refresh
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[07:59:30] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[07:59:30] [PASSED] drm_test_cmdline_res_margins_force_on
[07:59:30] [PASSED] drm_test_cmdline_res_vesa_margins
[07:59:30] [PASSED] drm_test_cmdline_name
[07:59:30] [PASSED] drm_test_cmdline_name_bpp
[07:59:30] [PASSED] drm_test_cmdline_name_option
[07:59:30] [PASSED] drm_test_cmdline_name_bpp_option
[07:59:30] [PASSED] drm_test_cmdline_rotate_0
[07:59:30] [PASSED] drm_test_cmdline_rotate_90
[07:59:30] [PASSED] drm_test_cmdline_rotate_180
[07:59:30] [PASSED] drm_test_cmdline_rotate_270
[07:59:30] [PASSED] drm_test_cmdline_hmirror
[07:59:30] [PASSED] drm_test_cmdline_vmirror
[07:59:30] [PASSED] drm_test_cmdline_margin_options
[07:59:30] [PASSED] drm_test_cmdline_multiple_options
[07:59:30] [PASSED] drm_test_cmdline_bpp_extra_and_option
[07:59:30] [PASSED] drm_test_cmdline_extra_and_option
[07:59:30] [PASSED] drm_test_cmdline_freestanding_options
[07:59:30] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[07:59:30] [PASSED] drm_test_cmdline_panel_orientation
[07:59:30] ================ drm_test_cmdline_invalid =================
[07:59:30] [PASSED] margin_only
[07:59:30] [PASSED] interlace_only
[07:59:30] [PASSED] res_missing_x
[07:59:30] [PASSED] res_missing_y
[07:59:30] [PASSED] res_bad_y
[07:59:30] [PASSED] res_missing_y_bpp
[07:59:30] [PASSED] res_bad_bpp
[07:59:30] [PASSED] res_bad_refresh
[07:59:30] [PASSED] res_bpp_refresh_force_on_off
[07:59:30] [PASSED] res_invalid_mode
[07:59:30] [PASSED] res_bpp_wrong_place_mode
[07:59:30] [PASSED] name_bpp_refresh
[07:59:30] [PASSED] name_refresh
[07:59:30] [PASSED] name_refresh_wrong_mode
[07:59:30] [PASSED] name_refresh_invalid_mode
[07:59:30] [PASSED] rotate_multiple
[07:59:30] [PASSED] rotate_invalid_val
[07:59:30] [PASSED] rotate_truncated
[07:59:30] [PASSED] invalid_option
[07:59:30] [PASSED] invalid_tv_option
[07:59:30] [PASSED] truncated_tv_option
[07:59:30] ============ [PASSED] drm_test_cmdline_invalid =============
[07:59:30] =============== drm_test_cmdline_tv_options ===============
[07:59:30] [PASSED] NTSC
[07:59:30] [PASSED] NTSC_443
[07:59:30] [PASSED] NTSC_J
[07:59:30] [PASSED] PAL
[07:59:30] [PASSED] PAL_M
[07:59:30] [PASSED] PAL_N
[07:59:30] [PASSED] SECAM
[07:59:30] [PASSED] MONO_525
[07:59:30] [PASSED] MONO_625
[07:59:30] =========== [PASSED] drm_test_cmdline_tv_options ===========
[07:59:30] =============== [PASSED] drm_cmdline_parser ================
[07:59:30] ========== drmm_connector_hdmi_init (20 subtests) ==========
[07:59:30] [PASSED] drm_test_connector_hdmi_init_valid
[07:59:30] [PASSED] drm_test_connector_hdmi_init_bpc_8
[07:59:30] [PASSED] drm_test_connector_hdmi_init_bpc_10
[07:59:30] [PASSED] drm_test_connector_hdmi_init_bpc_12
[07:59:30] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[07:59:30] [PASSED] drm_test_connector_hdmi_init_bpc_null
[07:59:30] [PASSED] drm_test_connector_hdmi_init_formats_empty
[07:59:30] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[07:59:30] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[07:59:30] [PASSED] supported_formats=0x9 yuv420_allowed=1
[07:59:30] [PASSED] supported_formats=0x9 yuv420_allowed=0
[07:59:30] [PASSED] supported_formats=0x3 yuv420_allowed=1
[07:59:30] [PASSED] supported_formats=0x3 yuv420_allowed=0
[07:59:30] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[07:59:30] [PASSED] drm_test_connector_hdmi_init_null_ddc
[07:59:30] [PASSED] drm_test_connector_hdmi_init_null_product
[07:59:30] [PASSED] drm_test_connector_hdmi_init_null_vendor
[07:59:30] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[07:59:30] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[07:59:30] [PASSED] drm_test_connector_hdmi_init_product_valid
[07:59:30] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[07:59:30] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[07:59:30] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[07:59:30] ========= drm_test_connector_hdmi_init_type_valid =========
[07:59:30] [PASSED] HDMI-A
[07:59:30] [PASSED] HDMI-B
[07:59:30] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[07:59:30] ======== drm_test_connector_hdmi_init_type_invalid ========
[07:59:30] [PASSED] Unknown
[07:59:30] [PASSED] VGA
[07:59:30] [PASSED] DVI-I
[07:59:30] [PASSED] DVI-D
[07:59:30] [PASSED] DVI-A
[07:59:30] [PASSED] Composite
[07:59:30] [PASSED] SVIDEO
[07:59:30] [PASSED] LVDS
[07:59:30] [PASSED] Component
[07:59:30] [PASSED] DIN
[07:59:30] [PASSED] DP
[07:59:30] [PASSED] TV
[07:59:30] [PASSED] eDP
[07:59:30] [PASSED] Virtual
[07:59:30] [PASSED] DSI
[07:59:30] [PASSED] DPI
[07:59:30] [PASSED] Writeback
[07:59:30] [PASSED] SPI
[07:59:30] [PASSED] USB
[07:59:30] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[07:59:30] ============ [PASSED] drmm_connector_hdmi_init =============
[07:59:30] ============= drmm_connector_init (3 subtests) =============
[07:59:30] [PASSED] drm_test_drmm_connector_init
[07:59:30] [PASSED] drm_test_drmm_connector_init_null_ddc
[07:59:30] ========= drm_test_drmm_connector_init_type_valid =========
[07:59:30] [PASSED] Unknown
[07:59:30] [PASSED] VGA
[07:59:30] [PASSED] DVI-I
[07:59:30] [PASSED] DVI-D
[07:59:30] [PASSED] DVI-A
[07:59:30] [PASSED] Composite
[07:59:30] [PASSED] SVIDEO
[07:59:30] [PASSED] LVDS
[07:59:30] [PASSED] Component
[07:59:30] [PASSED] DIN
[07:59:30] [PASSED] DP
[07:59:30] [PASSED] HDMI-A
[07:59:30] [PASSED] HDMI-B
[07:59:30] [PASSED] TV
[07:59:30] [PASSED] eDP
[07:59:30] [PASSED] Virtual
[07:59:30] [PASSED] DSI
[07:59:30] [PASSED] DPI
[07:59:30] [PASSED] Writeback
[07:59:30] [PASSED] SPI
[07:59:30] [PASSED] USB
[07:59:30] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[07:59:30] =============== [PASSED] drmm_connector_init ===============
[07:59:30] ========= drm_connector_dynamic_init (6 subtests) ==========
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_init
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_init_properties
[07:59:30] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[07:59:30] [PASSED] Unknown
[07:59:30] [PASSED] VGA
[07:59:30] [PASSED] DVI-I
[07:59:30] [PASSED] DVI-D
[07:59:30] [PASSED] DVI-A
[07:59:30] [PASSED] Composite
[07:59:30] [PASSED] SVIDEO
[07:59:30] [PASSED] LVDS
[07:59:30] [PASSED] Component
[07:59:30] [PASSED] DIN
[07:59:30] [PASSED] DP
[07:59:30] [PASSED] HDMI-A
[07:59:30] [PASSED] HDMI-B
[07:59:30] [PASSED] TV
[07:59:30] [PASSED] eDP
[07:59:30] [PASSED] Virtual
[07:59:30] [PASSED] DSI
[07:59:30] [PASSED] DPI
[07:59:30] [PASSED] Writeback
[07:59:30] [PASSED] SPI
[07:59:30] [PASSED] USB
[07:59:30] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[07:59:30] ======== drm_test_drm_connector_dynamic_init_name =========
[07:59:30] [PASSED] Unknown
[07:59:30] [PASSED] VGA
[07:59:30] [PASSED] DVI-I
[07:59:30] [PASSED] DVI-D
[07:59:30] [PASSED] DVI-A
[07:59:30] [PASSED] Composite
[07:59:30] [PASSED] SVIDEO
[07:59:30] [PASSED] LVDS
[07:59:30] [PASSED] Component
[07:59:30] [PASSED] DIN
[07:59:30] [PASSED] DP
[07:59:30] [PASSED] HDMI-A
[07:59:30] [PASSED] HDMI-B
[07:59:30] [PASSED] TV
[07:59:30] [PASSED] eDP
[07:59:30] [PASSED] Virtual
[07:59:30] [PASSED] DSI
[07:59:30] [PASSED] DPI
[07:59:30] [PASSED] Writeback
[07:59:30] [PASSED] SPI
[07:59:30] [PASSED] USB
[07:59:30] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[07:59:30] =========== [PASSED] drm_connector_dynamic_init ============
[07:59:30] ==== drm_connector_dynamic_register_early (4 subtests) =====
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[07:59:30] ====== [PASSED] drm_connector_dynamic_register_early =======
[07:59:30] ======= drm_connector_dynamic_register (7 subtests) ========
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[07:59:30] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[07:59:30] ========= [PASSED] drm_connector_dynamic_register ==========
[07:59:30] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[07:59:30] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[07:59:30] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[07:59:30] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[07:59:30] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[07:59:30] ========== drm_test_get_tv_mode_from_name_valid ===========
[07:59:30] [PASSED] NTSC
[07:59:30] [PASSED] NTSC-443
[07:59:30] [PASSED] NTSC-J
[07:59:30] [PASSED] PAL
[07:59:30] [PASSED] PAL-M
[07:59:30] [PASSED] PAL-N
[07:59:30] [PASSED] SECAM
[07:59:30] [PASSED] Mono
[07:59:30] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[07:59:30] [PASSED] drm_test_get_tv_mode_from_name_truncated
[07:59:30] ============ [PASSED] drm_get_tv_mode_from_name ============
[07:59:30] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[07:59:30] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[07:59:30] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[07:59:30] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[07:59:30] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[07:59:30] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[07:59:30] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[07:59:30] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[07:59:30] [PASSED] VIC 96
[07:59:30] [PASSED] VIC 97
[07:59:30] [PASSED] VIC 101
[07:59:30] [PASSED] VIC 102
[07:59:30] [PASSED] VIC 106
[07:59:30] [PASSED] VIC 107
[07:59:30] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[07:59:30] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[07:59:30] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[07:59:30] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[07:59:30] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[07:59:30] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[07:59:30] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[07:59:30] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[07:59:30] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[07:59:30] [PASSED] Automatic
[07:59:30] [PASSED] Full
[07:59:30] [PASSED] Limited 16:235
[07:59:30] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[07:59:30] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[07:59:30] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[07:59:30] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[07:59:30] === drm_test_drm_hdmi_connector_get_output_format_name ====
[07:59:30] [PASSED] RGB
[07:59:30] [PASSED] YUV 4:2:0
[07:59:30] [PASSED] YUV 4:2:2
[07:59:30] [PASSED] YUV 4:4:4
[07:59:30] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[07:59:30] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[07:59:30] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[07:59:30] ============= drm_damage_helper (21 subtests) ==============
[07:59:30] [PASSED] drm_test_damage_iter_no_damage
[07:59:30] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[07:59:30] [PASSED] drm_test_damage_iter_no_damage_src_moved
[07:59:30] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[07:59:30] [PASSED] drm_test_damage_iter_no_damage_not_visible
[07:59:30] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[07:59:30] [PASSED] drm_test_damage_iter_no_damage_no_fb
[07:59:30] [PASSED] drm_test_damage_iter_simple_damage
[07:59:30] [PASSED] drm_test_damage_iter_single_damage
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_outside_src
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_src_moved
[07:59:30] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[07:59:30] [PASSED] drm_test_damage_iter_damage
[07:59:30] [PASSED] drm_test_damage_iter_damage_one_intersect
[07:59:30] [PASSED] drm_test_damage_iter_damage_one_outside
[07:59:30] [PASSED] drm_test_damage_iter_damage_src_moved
[07:59:30] [PASSED] drm_test_damage_iter_damage_not_visible
[07:59:30] ================ [PASSED] drm_damage_helper ================
[07:59:30] ============== drm_dp_mst_helper (3 subtests) ==============
[07:59:30] ============== drm_test_dp_mst_calc_pbn_mode ==============
[07:59:30] [PASSED] Clock 154000 BPP 30 DSC disabled
[07:59:30] [PASSED] Clock 234000 BPP 30 DSC disabled
[07:59:30] [PASSED] Clock 297000 BPP 24 DSC disabled
[07:59:30] [PASSED] Clock 332880 BPP 24 DSC enabled
[07:59:30] [PASSED] Clock 324540 BPP 24 DSC enabled
[07:59:30] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[07:59:30] ============== drm_test_dp_mst_calc_pbn_div ===============
[07:59:30] [PASSED] Link rate 2000000 lane count 4
[07:59:30] [PASSED] Link rate 2000000 lane count 2
[07:59:30] [PASSED] Link rate 2000000 lane count 1
[07:59:30] [PASSED] Link rate 1350000 lane count 4
[07:59:30] [PASSED] Link rate 1350000 lane count 2
[07:59:30] [PASSED] Link rate 1350000 lane count 1
[07:59:30] [PASSED] Link rate 1000000 lane count 4
[07:59:30] [PASSED] Link rate 1000000 lane count 2
[07:59:30] [PASSED] Link rate 1000000 lane count 1
[07:59:30] [PASSED] Link rate 810000 lane count 4
[07:59:30] [PASSED] Link rate 810000 lane count 2
[07:59:30] [PASSED] Link rate 810000 lane count 1
[07:59:30] [PASSED] Link rate 540000 lane count 4
[07:59:30] [PASSED] Link rate 540000 lane count 2
[07:59:30] [PASSED] Link rate 540000 lane count 1
[07:59:30] [PASSED] Link rate 270000 lane count 4
[07:59:30] [PASSED] Link rate 270000 lane count 2
[07:59:30] [PASSED] Link rate 270000 lane count 1
[07:59:30] [PASSED] Link rate 162000 lane count 4
[07:59:30] [PASSED] Link rate 162000 lane count 2
[07:59:30] [PASSED] Link rate 162000 lane count 1
[07:59:30] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[07:59:30] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[07:59:30] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[07:59:30] [PASSED] DP_POWER_UP_PHY with port number
[07:59:30] [PASSED] DP_POWER_DOWN_PHY with port number
[07:59:30] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[07:59:30] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[07:59:30] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[07:59:30] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[07:59:30] [PASSED] DP_QUERY_PAYLOAD with port number
[07:59:30] [PASSED] DP_QUERY_PAYLOAD with VCPI
[07:59:30] [PASSED] DP_REMOTE_DPCD_READ with port number
[07:59:30] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[07:59:30] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[07:59:30] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[07:59:30] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[07:59:30] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[07:59:30] [PASSED] DP_REMOTE_I2C_READ with port number
[07:59:30] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[07:59:30] [PASSED] DP_REMOTE_I2C_READ with transactions array
[07:59:30] [PASSED] DP_REMOTE_I2C_WRITE with port number
[07:59:30] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[07:59:30] [PASSED] DP_REMOTE_I2C_WRITE with data array
[07:59:30] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[07:59:30] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[07:59:30] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[07:59:30] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[07:59:30] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[07:59:30] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[07:59:30] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[07:59:30] ================ [PASSED] drm_dp_mst_helper ================
[07:59:30] ================== drm_exec (7 subtests) ===================
[07:59:30] [PASSED] sanitycheck
[07:59:30] [PASSED] test_lock
[07:59:30] [PASSED] test_lock_unlock
[07:59:30] [PASSED] test_duplicates
[07:59:30] [PASSED] test_prepare
[07:59:30] [PASSED] test_prepare_array
[07:59:30] [PASSED] test_multiple_loops
[07:59:30] ==================== [PASSED] drm_exec =====================
[07:59:30] =========== drm_format_helper_test (18 subtests) ===========
[07:59:30] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] # drm_test_fb_xrgb8888_to_gray8: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:672
[07:59:30] Expected buf == result->expected, but
[07:59:30] buf ==
[07:59:30] ff 00 4c <95><1c><69><e2> b2
[07:59:30] result->expected ==
[07:59:30] ff 00 4c <99><19><66><e5> b2
[07:59:30] [FAILED] well_known_colors
[07:59:30] # drm_test_fb_xrgb8888_to_gray8: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_format_helper_test.c:672
[07:59:30] Expected buf == result->expected, but
[07:59:30] buf ==
[07:59:30] <3d><32><c1> 00 00 <ba><3d><32> 00 00 34 <ba><3d> 00 00
[07:59:30] result->expected ==
[07:59:30] <3c><33><c4> 00 00 <bb><3c><33> 00 00 34 <bb><3c> 00 00
[07:59:30] [FAILED] destination_pitch
[07:59:30] # drm_test_fb_xrgb8888_to_gray8: pass:2 fail:2 skip:0 total:4
[07:59:30] ========== [FAILED] drm_test_fb_xrgb8888_to_gray8 ==========
[07:59:30] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[07:59:30] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[07:59:30] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[07:59:30] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[07:59:30] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[07:59:30] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[07:59:30] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[07:59:30] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[07:59:30] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[07:59:30] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[07:59:30] ============== drm_test_fb_xrgb8888_to_mono ===============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[07:59:30] ==================== drm_test_fb_swab =====================
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ================ [PASSED] drm_test_fb_swab =================
[07:59:30] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[07:59:30] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[07:59:30] [PASSED] single_pixel_source_buffer
[07:59:30] [PASSED] single_pixel_clip_rectangle
[07:59:30] [PASSED] well_known_colors
[07:59:30] [PASSED] destination_pitch
[07:59:30] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[07:59:30] ================= drm_test_fb_clip_offset =================
[07:59:30] [PASSED] pass through
[07:59:30] [PASSED] horizontal offset
[07:59:30] [PASSED] vertical offset
[07:59:30] [PASSED] horizontal and vertical offset
[07:59:30] [PASSED] horizontal offset (custom pitch)
[07:59:30] [PASSED] vertical offset (custom pitch)
[07:59:30] [PASSED] horizontal and vertical offset (custom pitch)
[07:59:30] ============= [PASSED] drm_test_fb_clip_offset =============
[07:59:30] ============== drm_test_fb_build_fourcc_list ==============
[07:59:30] [PASSED] no native formats
[07:59:30] [PASSED] XRGB8888 as native format
[07:59:30] [PASSED] remove duplicates
[07:59:30] [PASSED] convert alpha formats
[07:59:30] [PASSED] random formats
[07:59:30] ========== [PASSED] drm_test_fb_build_fourcc_list ==========
[07:59:30] =================== drm_test_fb_memcpy ====================
[07:59:30] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[07:59:30] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[07:59:30] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[07:59:30] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[07:59:30] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[07:59:30] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[07:59:30] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[07:59:30] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[07:59:30] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[07:59:30] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[07:59:30] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[07:59:30] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[07:59:30] =============== [PASSED] drm_test_fb_memcpy ================
[07:59:30] # module: drm_format_helper_test
[07:59:30] # drm_format_helper_test: pass:17 fail:1 skip:0 total:18
[07:59:30] # Totals: pass:82 fail:2 skip:0 total:84
[07:59:30] ============= [FAILED] drm_format_helper_test ==============
[07:59:30] ================= drm_format (18 subtests) =================
[07:59:30] [PASSED] drm_test_format_block_width_invalid
[07:59:30] [PASSED] drm_test_format_block_width_one_plane
[07:59:30] [PASSED] drm_test_format_block_width_two_plane
[07:59:30] [PASSED] drm_test_format_block_width_three_plane
[07:59:30] [PASSED] drm_test_format_block_width_tiled
[07:59:30] [PASSED] drm_test_format_block_height_invalid
[07:59:30] [PASSED] drm_test_format_block_height_one_plane
[07:59:30] [PASSED] drm_test_format_block_height_two_plane
[07:59:30] [PASSED] drm_test_format_block_height_three_plane
[07:59:30] [PASSED] drm_test_format_block_height_tiled
[07:59:30] [PASSED] drm_test_format_min_pitch_invalid
[07:59:30] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[07:59:30] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[07:59:30] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[07:59:30] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[07:59:30] [PASSED] drm_test_format_min_pitch_two_plane
[07:59:30] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[07:59:30] [PASSED] drm_test_format_min_pitch_tiled
[07:59:30] =================== [PASSED] drm_format ====================
[07:59:30] ============== drm_framebuffer (10 subtests) ===============
[07:59:30] ========== drm_test_framebuffer_check_src_coords ==========
[07:59:30] [PASSED] Success: source fits into fb
[07:59:30] [PASSED] Fail: overflowing fb with x-axis coordinate
[07:59:30] [PASSED] Fail: overflowing fb with y-axis coordinate
[07:59:30] [PASSED] Fail: overflowing fb with source width
[07:59:30] [PASSED] Fail: overflowing fb with source height
[07:59:30] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[07:59:30] [PASSED] drm_test_framebuffer_cleanup
[07:59:30] =============== drm_test_framebuffer_create ===============
[07:59:30] [PASSED] ABGR8888 normal sizes
[07:59:30] [PASSED] ABGR8888 max sizes
[07:59:30] [PASSED] ABGR8888 pitch greater than min required
[07:59:30] [PASSED] ABGR8888 pitch less than min required
[07:59:30] [PASSED] ABGR8888 Invalid width
[07:59:30] [PASSED] ABGR8888 Invalid buffer handle
[07:59:30] [PASSED] No pixel format
[07:59:30] [PASSED] ABGR8888 Width 0
[07:59:30] [PASSED] ABGR8888 Height 0
[07:59:30] [PASSED] ABGR8888 Out of bound height * pitch combination
[07:59:30] [PASSED] ABGR8888 Large buffer offset
[07:59:30] [PASSED] ABGR8888 Buffer offset for inexistent plane
[07:59:30] [PASSED] ABGR8888 Invalid flag
[07:59:30] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[07:59:30] [PASSED] ABGR8888 Valid buffer modifier
[07:59:30] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[07:59:30] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] NV12 Normal sizes
[07:59:30] [PASSED] NV12 Max sizes
[07:59:30] [PASSED] NV12 Invalid pitch
[07:59:30] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[07:59:30] [PASSED] NV12 different modifier per-plane
[07:59:30] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[07:59:30] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] NV12 Modifier for inexistent plane
[07:59:30] [PASSED] NV12 Handle for inexistent plane
[07:59:30] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[07:59:30] [PASSED] YVU420 Normal sizes
[07:59:30] [PASSED] YVU420 Max sizes
[07:59:30] [PASSED] YVU420 Invalid pitch
[07:59:30] [PASSED] YVU420 Different pitches
[07:59:30] [PASSED] YVU420 Different buffer offsets/pitches
[07:59:30] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[07:59:30] [PASSED] YVU420 Valid modifier
[07:59:30] [PASSED] YVU420 Different modifiers per plane
[07:59:30] [PASSED] YVU420 Modifier for inexistent plane
[07:59:30] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[07:59:30] [PASSED] X0L2 Normal sizes
[07:59:30] [PASSED] X0L2 Max sizes
[07:59:30] [PASSED] X0L2 Invalid pitch
[07:59:30] [PASSED] X0L2 Pitch greater than minimum required
[07:59:30] [PASSED] X0L2 Handle for inexistent plane
[07:59:30] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[07:59:30] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[07:59:30] [PASSED] X0L2 Valid modifier
[07:59:30] [PASSED] X0L2 Modifier for inexistent plane
[07:59:30] =========== [PASSED] drm_test_framebuffer_create ===========
[07:59:30] [PASSED] drm_test_framebuffer_free
[07:59:30] [PASSED] drm_test_framebuffer_init
[07:59:30] [PASSED] drm_test_framebuffer_init_bad_format
[07:59:30] [PASSED] drm_test_framebuffer_init_dev_mismatch
[07:59:30] [PASSED] drm_test_framebuffer_lookup
[07:59:30] [PASSED] drm_test_framebuffer_lookup_inexistent
[07:59:30] [PASSED] drm_test_framebuffer_modifiers_not_supported
[07:59:30] ================= [PASSED] drm_framebuffer =================
[07:59:30] ================ drm_gem_shmem (8 subtests) ================
[07:59:30] [PASSED] drm_gem_shmem_test_obj_create
[07:59:30] [PASSED] drm_gem_shmem_test_obj_create_private
[07:59:30] [PASSED] drm_gem_shmem_test_pin_pages
[07:59:30] [PASSED] drm_gem_shmem_test_vmap
[07:59:30] [PASSED] drm_gem_shmem_test_get_pages_sgt
[07:59:30] [PASSED] drm_gem_shmem_test_get_sg_table
[07:59:30] [PASSED] drm_gem_shmem_test_madvise
[07:59:30] [PASSED] drm_gem_shmem_test_purge
[07:59:30] ================== [PASSED] drm_gem_shmem ==================
[07:59:30] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[07:59:30] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 =======
[07:59:30] [PASSED] Automatic
[07:59:30] [PASSED] Full
[07:59:30] [PASSED] Limited 16:235
[07:59:30] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[07:59:30] [PASSED] drm_test_check_disable_connector
[07:59:30] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[07:59:30] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[07:59:30] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[07:59:30] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[07:59:30] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[07:59:30] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[07:59:30] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[07:59:30] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[07:59:30] [PASSED] drm_test_check_output_bpc_dvi
[07:59:30] [PASSED] drm_test_check_output_bpc_format_vic_1
[07:59:30] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[07:59:30] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[07:59:30] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[07:59:30] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[07:59:30] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[07:59:30] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[07:59:30] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[07:59:30] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[07:59:30] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[07:59:30] [PASSED] drm_test_check_broadcast_rgb_value
[07:59:30] [PASSED] drm_test_check_bpc_8_value
[07:59:30] [PASSED] drm_test_check_bpc_10_value
[07:59:30] [PASSED] drm_test_check_bpc_12_value
[07:59:30] [PASSED] drm_test_check_format_value
[07:59:30] [PASSED] drm_test_check_tmds_char_value
[07:59:30] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[07:59:30] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[07:59:30] [PASSED] drm_test_check_mode_valid
[07:59:30] [PASSED] drm_test_check_mode_valid_reject
[07:59:30] [PASSED] drm_test_check_mode_valid_reject_rate
[07:59:30] [PASSED] drm_test_check_mode_valid_reject_max_clock
[07:59:30] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[07:59:30] ================= drm_managed (2 subtests) =================
[07:59:30] [PASSED] drm_test_managed_release_action
[07:59:30] [PASSED] drm_test_managed_run_action
[07:59:30] =================== [PASSED] drm_managed ===================
[07:59:30] =================== drm_mm (6 subtests) ====================
[07:59:30] [PASSED] drm_test_mm_init
[07:59:30] [PASSED] drm_test_mm_debug
[07:59:30] [PASSED] drm_test_mm_align32
[07:59:30] [PASSED] drm_test_mm_align64
[07:59:30] [PASSED] drm_test_mm_lowest
[07:59:30] [PASSED] drm_test_mm_highest
[07:59:30] ===================== [PASSED] drm_mm ======================
[07:59:30] ============= drm_modes_analog_tv (5 subtests) =============
[07:59:30] [PASSED] drm_test_modes_analog_tv_mono_576i
[07:59:30] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[07:59:30] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[07:59:30] [PASSED] drm_test_modes_analog_tv_pal_576i
[07:59:30] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[07:59:30] =============== [PASSED] drm_modes_analog_tv ===============
[07:59:30] ============== drm_plane_helper (2 subtests) ===============
[07:59:30] =============== drm_test_check_plane_state ================
[07:59:30] [PASSED] clipping_simple
[07:59:30] [PASSED] clipping_rotate_reflect
[07:59:30] [PASSED] positioning_simple
[07:59:30] [PASSED] upscaling
[07:59:30] [PASSED] downscaling
[07:59:30] [PASSED] rounding1
[07:59:30] [PASSED] rounding2
[07:59:30] [PASSED] rounding3
[07:59:30] [PASSED] rounding4
[07:59:30] =========== [PASSED] drm_test_check_plane_state ============
[07:59:30] =========== drm_test_check_invalid_plane_state ============
[07:59:30] [PASSED] positioning_invalid
[07:59:30] [PASSED] upscaling_invalid
[07:59:30] [PASSED] downscaling_invalid
[07:59:30] ======= [PASSED] drm_test_check_invalid_plane_state ========
[07:59:30] ================ [PASSED] drm_plane_helper =================
[07:59:30] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[07:59:30] ====== drm_test_connector_helper_tv_get_modes_check =======
[07:59:30] [PASSED] None
[07:59:30] [PASSED] PAL
[07:59:30] [PASSED] NTSC
[07:59:30] [PASSED] Both, NTSC Default
[07:59:30] [PASSED] Both, PAL Default
[07:59:30] [PASSED] Both, NTSC Default, with PAL on command-line
[07:59:30] [PASSED] Both, PAL Default, with NTSC on command-line
[07:59:30] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[07:59:30] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[07:59:30] ================== drm_rect (9 subtests) ===================
[07:59:30] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[07:59:30] [PASSED] drm_test_rect_clip_scaled_not_clipped
[07:59:30] [PASSED] drm_test_rect_clip_scaled_clipped
[07:59:30] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[07:59:30] ================= drm_test_rect_intersect =================
[07:59:30] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[07:59:30] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[07:59:30] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[07:59:30] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[07:59:30] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[07:59:30] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[07:59:30] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[07:59:30] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[07:59:30] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[07:59:30] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[07:59:30] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[07:59:30] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
stty: 'standard input': Inappropriate ioctl for device
[07:59:30] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[07:59:30] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[07:59:30] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[07:59:30] ============= [PASSED] drm_test_rect_intersect =============
[07:59:30] ================ drm_test_rect_calc_hscale ================
[07:59:30] [PASSED] normal use
[07:59:30] [PASSED] out of max range
[07:59:30] [PASSED] out of min range
[07:59:30] [PASSED] zero dst
[07:59:30] [PASSED] negative src
[07:59:30] [PASSED] negative dst
[07:59:30] ============ [PASSED] drm_test_rect_calc_hscale ============
[07:59:30] ================ drm_test_rect_calc_vscale ================
[07:59:30] [PASSED] normal use
[07:59:30] [PASSED] out of max range
[07:59:30] [PASSED] out of min range
[07:59:30] [PASSED] zero dst
[07:59:30] [PASSED] negative src
[07:59:30] [PASSED] negative dst
[07:59:30] ============ [PASSED] drm_test_rect_calc_vscale ============
[07:59:30] ================== drm_test_rect_rotate ===================
[07:59:30] [PASSED] reflect-x
[07:59:30] [PASSED] reflect-y
[07:59:30] [PASSED] rotate-0
[07:59:30] [PASSED] rotate-90
[07:59:30] [PASSED] rotate-180
[07:59:30] [PASSED] rotate-270
[07:59:30] ============== [PASSED] drm_test_rect_rotate ===============
[07:59:30] ================ drm_test_rect_rotate_inv =================
[07:59:30] [PASSED] reflect-x
[07:59:30] [PASSED] reflect-y
[07:59:30] [PASSED] rotate-0
[07:59:30] [PASSED] rotate-90
[07:59:30] [PASSED] rotate-180
[07:59:30] [PASSED] rotate-270
[07:59:30] ============ [PASSED] drm_test_rect_rotate_inv =============
[07:59:30] ==================== [PASSED] drm_rect =====================
[07:59:30] ============================================================
[07:59:30] Testing complete. Ran 616 tests: passed: 614, failed: 2
[07:59:30] Failures: drm_format_helper_test.drm_test_fb_xrgb8888_to_gray8.well_known_colors, drm_format_helper_test.drm_test_fb_xrgb8888_to_gray8.destination_pitch
[07:59:30] Elapsed time: 44.579s total, 2.552s configuring, 41.753s building, 0.215s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64
2025-06-13 6:12 [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64 Ankit Nautiyal
2025-06-13 7:59 ` ✗ CI.KUnit: failure for " Patchwork
@ 2025-06-13 9:21 ` Kandpal, Suraj
2025-06-13 9:36 ` Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Kandpal, Suraj @ 2025-06-13 9:21 UTC (permalink / raw)
To: Nautiyal, Ankit K, intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com,
stable@vger.kernel.org
> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
> Sent: Friday, June 13, 2025 11:43 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org; Kandpal, Suraj <suraj.kandpal@intel.com>;
> jani.nikula@linux.intel.com; stable@vger.kernel.org
> Subject: [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by
> using div64_u64
>
> DIV_ROUND_CLOSEST_ULL uses do_div(), which expects a 32-bit divisor.
> When passing a 64-bit constant like CURVE2_MULTIPLIER, the value is silently
> truncated to u32, potentially leading to incorrect results on large divisors.
>
> Replace DIV_ROUND_CLOSEST_ULL with div64_u64(), which correctly handles
> full 64-bit division. Since the result is clamped between
> 1 and 127, rounding is unnecessary and truncating division is sufficient.
>
> Fixes: 5947642004bf ("drm/i915/display: Add support for SNPS PHY HDMI PLL
> algorithm for DG2")
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: <stable@vger.kernel.org> # v6.15+
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> index 74bb3bedf30f..ac609bdf6653 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> @@ -103,8 +103,8 @@ static void get_ana_cp_int_prop(u64 vco_clk,
> DIV_ROUND_DOWN_ULL(curve_1_interpolated,
> CURVE0_MULTIPLIER)));
>
> ana_cp_int_temp =
> -
> DIV_ROUND_CLOSEST_ULL(DIV_ROUND_DOWN_ULL(adjusted_vco_cl
> k1, curve_2_scaled1),
> - CURVE2_MULTIPLIER);
> + div64_u64(DIV_ROUND_DOWN_ULL(adjusted_vco_clk1,
> curve_2_scaled1),
> + CURVE2_MULTIPLIER);
>
> *ana_cp_int = max(1, min(ana_cp_int_temp, 127));
>
> --
> 2.45.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64
2025-06-13 6:12 [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64 Ankit Nautiyal
2025-06-13 7:59 ` ✗ CI.KUnit: failure for " Patchwork
2025-06-13 9:21 ` [PATCH] " Kandpal, Suraj
@ 2025-06-13 9:36 ` Jani Nikula
2025-06-15 15:18 ` Nautiyal, Ankit K
2 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2025-06-13 9:36 UTC (permalink / raw)
To: Ankit Nautiyal, intel-gfx; +Cc: intel-xe, suraj.kandpal, stable
On Fri, 13 Jun 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
> DIV_ROUND_CLOSEST_ULL uses do_div(), which expects a 32-bit divisor.
> When passing a 64-bit constant like CURVE2_MULTIPLIER, the value is
> silently truncated to u32, potentially leading to incorrect results
> on large divisors.
>
> Replace DIV_ROUND_CLOSEST_ULL with div64_u64(), which correctly
> handles full 64-bit division. Since the result is clamped between
> 1 and 127, rounding is unnecessary and truncating division
> is sufficient.
I don't understand how you can make that conclusion. Please explain.
Would it be safer to just use DIV64_U64_ROUND_CLOSEST()?
> Fixes: 5947642004bf ("drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2")
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: <stable@vger.kernel.org> # v6.15+
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> index 74bb3bedf30f..ac609bdf6653 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> @@ -103,8 +103,8 @@ static void get_ana_cp_int_prop(u64 vco_clk,
> DIV_ROUND_DOWN_ULL(curve_1_interpolated, CURVE0_MULTIPLIER)));
>
> ana_cp_int_temp =
> - DIV_ROUND_CLOSEST_ULL(DIV_ROUND_DOWN_ULL(adjusted_vco_clk1, curve_2_scaled1),
> - CURVE2_MULTIPLIER);
> + div64_u64(DIV_ROUND_DOWN_ULL(adjusted_vco_clk1, curve_2_scaled1),
> + CURVE2_MULTIPLIER);
>
> *ana_cp_int = max(1, min(ana_cp_int_temp, 127));
Unrelated to this patch, but this should be:
*ana_cp_int = clamp(ana_cp_int_temp, 1, 127);
There's a similar issue with ana_cp_prop also in the file.
BR,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64
2025-06-13 9:36 ` Jani Nikula
@ 2025-06-15 15:18 ` Nautiyal, Ankit K
2025-06-16 8:18 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Nautiyal, Ankit K @ 2025-06-15 15:18 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: intel-xe, suraj.kandpal, stable
[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]
On 6/13/2025 3:06 PM, Jani Nikula wrote:
> On Fri, 13 Jun 2025, Ankit Nautiyal<ankit.k.nautiyal@intel.com> wrote:
>> DIV_ROUND_CLOSEST_ULL uses do_div(), which expects a 32-bit divisor.
>> When passing a 64-bit constant like CURVE2_MULTIPLIER, the value is
>> silently truncated to u32, potentially leading to incorrect results
>> on large divisors.
>>
>> Replace DIV_ROUND_CLOSEST_ULL with div64_u64(), which correctly
>> handles full 64-bit division. Since the result is clamped between
>> 1 and 127, rounding is unnecessary and truncating division
>> is sufficient.
> I don't understand how you can make that conclusion. Please explain.
>
> Would it be safer to just use DIV64_U64_ROUND_CLOSEST()?
I was thinking in terms of the boundary values that less than 1 will be
rounded to 1 and anything > 127 will round to 127.
But my reasoning about rounding being unnecessary was flawed, as any
thing in between will indeed matter.
Moreover on checking with spec the algorithm too uses ROUND function.
You are right, DIV64_U64_ROUND_CLOSEST is a better choice here.
>
>> Fixes: 5947642004bf ("drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2")
>> Cc: Ankit Nautiyal<ankit.k.nautiyal@intel.com>
>> Cc: Suraj Kandpal<suraj.kandpal@intel.com>
>> Cc: Jani Nikula<jani.nikula@intel.com>
>> Cc:<stable@vger.kernel.org> # v6.15+
>> Signed-off-by: Ankit Nautiyal<ankit.k.nautiyal@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
>> index 74bb3bedf30f..ac609bdf6653 100644
>> --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
>> +++ b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
>> @@ -103,8 +103,8 @@ static void get_ana_cp_int_prop(u64 vco_clk,
>> DIV_ROUND_DOWN_ULL(curve_1_interpolated, CURVE0_MULTIPLIER)));
>>
>> ana_cp_int_temp =
>> - DIV_ROUND_CLOSEST_ULL(DIV_ROUND_DOWN_ULL(adjusted_vco_clk1, curve_2_scaled1),
>> - CURVE2_MULTIPLIER);
>> + div64_u64(DIV_ROUND_DOWN_ULL(adjusted_vco_clk1, curve_2_scaled1),
>> + CURVE2_MULTIPLIER);
>>
>> *ana_cp_int = max(1, min(ana_cp_int_temp, 127));
> Unrelated to this patch, but this should be:
>
> *ana_cp_int = clamp(ana_cp_int_temp, 1, 127);
>
> There's a similar issue with ana_cp_prop also in the file.
>
Agreed. Should there be a separate patch for this?
Regards,
Ankit
> BR,
> Jani.
>
>
[-- Attachment #2: Type: text/html, Size: 4020 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/snps_hdmi_pll: Fix 64-bit divisor truncation by using div64_u64
2025-06-15 15:18 ` Nautiyal, Ankit K
@ 2025-06-16 8:18 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2025-06-16 8:18 UTC (permalink / raw)
To: Nautiyal, Ankit K, intel-gfx; +Cc: intel-xe, suraj.kandpal, stable
On Sun, 15 Jun 2025, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
> On 6/13/2025 3:06 PM, Jani Nikula wrote:
>> On Fri, 13 Jun 2025, Ankit Nautiyal<ankit.k.nautiyal@intel.com> wrote:
>>> *ana_cp_int = max(1, min(ana_cp_int_temp, 127));
>> Unrelated to this patch, but this should be:
>>
>> *ana_cp_int = clamp(ana_cp_int_temp, 1, 127);
>>
>> There's a similar issue with ana_cp_prop also in the file.
>>
> Agreed. Should there be a separate patch for this?
Yes. That's why I emphasized "unrelated to this patch". ;)
BR,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread