Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/gsc: Make GSCCS disabling message less alarming
@ 2024-12-19  1:09 Daniele Ceraolo Spurio
  2024-12-19  1:51 ` John Harrison
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Daniele Ceraolo Spurio @ 2024-12-19  1:09 UTC (permalink / raw)
  To: intel-xe; +Cc: Daniele Ceraolo Spurio, Eero Tamminen

The GSCCS is only used to transport messages from the driver to the GSC
FW; therefore, we can disable it if we're not using the FW, which is
the case on both BMG and PTL. However, the current wording of the logged
message could be interpreted as a problem, so reword to make it clearer
it is not an error and lower it debug verbosity as users don't really
need to know about it.

Reported-by: Eero Tamminen <eero.t.tamminen@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3866
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/xe/xe_hw_engine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
index 4294aa600192..ac9c666a9652 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
@@ -775,7 +775,7 @@ static void check_gsc_availability(struct xe_gt *gt)
 		xe_mmio_write32(&gt->mmio, GUNIT_GSC_INTR_ENABLE, 0);
 		xe_mmio_write32(&gt->mmio, GUNIT_GSC_INTR_MASK, ~0);
 
-		drm_info(&xe->drm, "gsccs disabled due to lack of FW\n");
+		drm_dbg(&xe->drm, "GSC FW not used, disabling gsccs\n");
 	}
 }
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-12-20  9:13 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19  1:09 [PATCH] drm/xe/gsc: Make GSCCS disabling message less alarming Daniele Ceraolo Spurio
2024-12-19  1:51 ` John Harrison
2024-12-19 21:06   ` Daniele Ceraolo Spurio
2024-12-19 22:17     ` John Harrison
2024-12-19  5:11 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-19  5:11 ` ✓ CI.checkpatch: " Patchwork
2024-12-19  5:12 ` ✓ CI.KUnit: " Patchwork
2024-12-19  5:30 ` ✓ CI.Build: " Patchwork
2024-12-19  5:32 ` ✓ CI.Hooks: " Patchwork
2024-12-19  5:34 ` ✓ CI.checksparse: " Patchwork
2024-12-19  9:47 ` ✓ CI.BAT: " Patchwork
2024-12-20  9:13 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox