Re: [PATCH v5 1/2] drm/xe/regs/xe_pmt: Macros for G-State and pcie link state residency offset

["Poosa, Karthik" <karthik.poosa@intel.com>]

On 22-06-2025 11:27, Gupta, Anshuman wrote:
>
>> -----Original Message-----
>> From: Purkait, Soham <soham.purkait@intel.com>
>> Sent: Friday, June 20, 2025 5:34 PM
>> To: intel-xe@lists.freedesktop.org; Gupta, Anshuman
>> <anshuman.gupta@intel.com>; Nilawar, Badal <badal.nilawar@intel.com>;
>> Poosa, Karthik <karthik.poosa@intel.com>; Tauro, Riana
>> <riana.tauro@intel.com>; Cavitt, Jonathan <jonathan.cavitt@intel.com>
>> Cc: De Marchi, Lucas <lucas.demarchi@intel.com>; Purkait, Soham
>> <soham.purkait@intel.com>; Dixit, Ashutosh <ashutosh.dixit@intel.com>;
>> Nikula, Jani <jani.nikula@intel.com>
>> Subject: [PATCH v5 1/2] drm/xe/regs/xe_pmt: Macros for G-State and pcie link
>> state residency offset
>>
>>     Add G-State residency and pcie link state residency offset macros for G2, G6,
>> G8, G10, ModS and L0, L1, L1.2 respectively.
>>
>> v1 : Moved offset macros to drm/xe/regs/xe_pmt. (Riana)
Move offset
>>
>> v5 : Reordered commits to reflect the correct dependency hierarchy.
The need not be mentioned here. Having this mentioned in cover letter 
should be fine.
>> (Jonathan)
>>
>> Signed-off-by: Soham Purkait <soham.purkait@intel.com>
>> ---
>>   drivers/gpu/drm/xe/regs/xe_pmt.h | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/regs/xe_pmt.h
>> b/drivers/gpu/drm/xe/regs/xe_pmt.h
>> index b0efd9b48d1e..4e377b6eac92 100644
>> --- a/drivers/gpu/drm/xe/regs/xe_pmt.h
>> +++ b/drivers/gpu/drm/xe/regs/xe_pmt.h
>> @@ -21,4 +21,14 @@
>>   #define SG_REMAP_INDEX1			XE_REG(SOC_BASE + 0x08)
>>   #define   SG_REMAP_BITS			REG_GENMASK(31, 24)
>>
>> +#define BMG_G2_RESIDENCY_OFFSET			(0x530)
>> +#define BMG_G6_RESIDENCY_OFFSET			(0x538)
>> +#define BMG_G8_RESIDENCY_OFFSET			(0x540)
>> +#define BMG_G10_RESIDENCY_OFFSET		(0x548)
>> +#define BMG_MODS_RESIDENCY_OFFSET		(0x4D0)
>> +
>> +#define PCIE_LINK_L0_RESIDENCY_COUNTER		(0x570)
>> +#define PCIE_LINK_L1_RESIDENCY_COUNTER		(0x578)
>> +#define PCIE_LINK_L1_2_RESIDENCY_COUNTER	(0x580)
> If these are BMG specific offset, these should be prefixed with BMG.
>
> Thanks,
> Anshuman.
Agree with Anshuman on this.
>> +
>>   #endif
>> --
>> 2.34.1