Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/guc: Configure TLB timeout based on CT buffer size
@ 2024-06-25  8:49 Nirmoy Das
  2024-06-25  9:09 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (9 more replies)
  0 siblings, 10 replies; 16+ messages in thread
From: Nirmoy Das @ 2024-06-25  8:49 UTC (permalink / raw)
  To: intel-xe; +Cc: Nirmoy Das, Matthew Brost, Daniele Ceraolo Spurio

GuC TLB invalidation depends on GuC to process the request from the CT
queue and then the real time to invalidate TLB. Add a function to return
overestimated possible time a TLB inval H2G might take which can be used
as timeout value for TLB invalidation wait time.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1622
Cc: Matthew Brost <matthew.brost@intel.com>
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |  2 +-
 drivers/gpu/drm/xe/xe_guc_ct.c              | 12 ++++++++++++
 drivers/gpu/drm/xe/xe_guc_ct.h              |  2 ++
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
index e1f1ccb01143..fa61070d6201 100644
--- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
+++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
@@ -17,7 +17,7 @@
 #include "xe_trace.h"
 #include "regs/xe_guc_regs.h"
 
-#define TLB_TIMEOUT	(HZ / 4)
+#define TLB_TIMEOUT	xe_guc_tlb_timeout_jiffies()
 
 static void xe_gt_tlb_fence_timeout(struct work_struct *work)
 {
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index b4137fe195a4..e30c0da86acc 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -112,6 +112,18 @@ ct_to_xe(struct xe_guc_ct *ct)
 #define CTB_G2H_BUFFER_SIZE	(4 * CTB_H2G_BUFFER_SIZE)
 #define G2H_ROOM_BUFFER_SIZE	(CTB_G2H_BUFFER_SIZE / 4)
 
+/**
+ * xe_guc_tlb_timeout_jiffies - Calculate the maximum time to process a tlb inval command
+ *
+ * This function computes the maximum time to process a tlb inval H2G commands
+ * in jiffies. A 4KB buffer full of commands takes a little over a second to process,
+ * so this time is set to 2 seconds to be safe.
+ */
+long xe_guc_tlb_timeout_jiffies(void)
+{
+	return (CTB_H2G_BUFFER_SIZE * HZ) / SZ_2K;
+}
+
 static size_t guc_ct_size(void)
 {
 	return 2 * CTB_DESC_SIZE + CTB_H2G_BUFFER_SIZE +
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.h b/drivers/gpu/drm/xe/xe_guc_ct.h
index 105bb8e99a8d..a9755574d6c9 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.h
+++ b/drivers/gpu/drm/xe/xe_guc_ct.h
@@ -64,4 +64,6 @@ xe_guc_ct_send_block_no_fail(struct xe_guc_ct *ct, const u32 *action, u32 len)
 	return xe_guc_ct_send_recv_no_fail(ct, action, len, NULL);
 }
 
+long xe_guc_tlb_timeout_jiffies(void);
+
 #endif
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-06-26  7:58 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-25  8:49 [PATCH] drm/xe/guc: Configure TLB timeout based on CT buffer size Nirmoy Das
2024-06-25  9:09 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-25  9:09 ` ✓ CI.checkpatch: " Patchwork
2024-06-25  9:10 ` ✓ CI.KUnit: " Patchwork
2024-06-25  9:22 ` ✓ CI.Build: " Patchwork
2024-06-25  9:24 ` ✗ CI.Hooks: failure " Patchwork
2024-06-25  9:25 ` ✓ CI.checksparse: success " Patchwork
2024-06-25  9:48 ` ✓ CI.BAT: " Patchwork
2024-06-25 11:44 ` ✓ CI.FULL: " Patchwork
2024-06-25 19:55 ` [PATCH] " Michal Wajdeczko
2024-06-26  7:15   ` Nirmoy Das
2024-06-25 22:12 ` Matthew Brost
2024-06-26  7:33   ` Nirmoy Das
2024-06-26  7:41     ` Matthew Brost
2024-06-26  7:51       ` Nirmoy Das
2024-06-26  7:57     ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox