Re: [PATCH v6] drm/xe: Add helper function to inject fault into ct_dead_capture()

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 05 Jun 2025, John Harrison <john.c.harrison@intel.com> wrote:
> On 5/24/2025 7:46 AM, Satyanarayana K V P wrote:
>> When injecting fault to xe_guc_ct_send_recv() & xe_guc_mmio_send_recv()
>> functions, the CI test systems are going out of space and crashing. To
>> avoid this issue, a new helper function is created and when fault is
>> injected into this xe_inject_fault() helper function, ct dead capture
>> is avoided which suppresses ct dumps in the log.
>>
>> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
>> Suggested-by: John Harrison <John.C.Harrison@Intel.com>
> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
>
> This seems like the simplest and cleanest solution to me (for both the 
> KMD and the IGT sides). I don't know if Jani or Michal still have 
> objections to it.

Simple it may be, but I still think it conflates two orthogonal things
that should both be decided by userspace.

If userspace wants error injection, why should the kernel decide it
means no error capture in dmesg? Especially when that decision is to
tackle an arbitrary self-inflicted *userspace* issue i.e. disk space
limitation during testing.

Mechanism, not policy.

There, I've said it, but this is not a hill I'm going to die on.


BR,
Jani.


-- 
Jani Nikula, Intel