Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/fbc: Apply Wa_14028723391
@ 2026-10-23 12:06 Vinod Govindapillai
  2026-10-23 12:25 ` sashiko-bot
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Vinod Govindapillai @ 2026-10-23 12:06 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: vinod.govindapillai

Disable FBC in XE3P_LPD for FP16 formats with Alpha.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_wa.c |  2 ++
 drivers/gpu/drm/i915/display/intel_display_wa.h |  1 +
 drivers/gpu/drm/i915/display/intel_fbc.c        | 12 ++++++++++++
 3 files changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_wa.c b/drivers/gpu/drm/i915/display/intel_display_wa.c
index 2e3ff4861ef4..82882fff5987 100644
--- a/drivers/gpu/drm/i915/display/intel_display_wa.c
+++ b/drivers/gpu/drm/i915/display/intel_display_wa.c
@@ -146,6 +146,8 @@ bool __intel_display_wa(struct intel_display *display, enum intel_display_wa wa,
 		return IS_DISPLAY_VERx100(display, 1100, 1400);
 	case INTEL_DISPLAY_WA_22021048059:
 		return IS_DISPLAY_VER(display, 14, 35);
+	case INTEL_DISPLAY_WA_14028723391:
+		return DISPLAY_VER(display) == 35;
 	default:
 		drm_WARN(display->drm, 1, "Missing Wa: %s\n", name);
 		break;
diff --git a/drivers/gpu/drm/i915/display/intel_display_wa.h b/drivers/gpu/drm/i915/display/intel_display_wa.h
index b707147a7587..205605e0f941 100644
--- a/drivers/gpu/drm/i915/display/intel_display_wa.h
+++ b/drivers/gpu/drm/i915/display/intel_display_wa.h
@@ -53,6 +53,7 @@ enum intel_display_wa {
 	INTEL_DISPLAY_WA_22012358565,
 	INTEL_DISPLAY_WA_22014263786,
 	INTEL_DISPLAY_WA_22021048059,
+	INTEL_DISPLAY_WA_14028723391,
 };
 
 bool __intel_display_wa(struct intel_display *display, enum intel_display_wa wa, const char *name);
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 5694d20773f8..80a7ae671179 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1687,6 +1687,18 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
 		return 0;
 	}
 
+	/*
+	 * Wa_14028723391:
+	 * Fixes: Screen corruption with FBC enabled on a plane with the FP16
+	 * Workaround: Disable FBC for FP16+Alpha in xe3p_lpd
+	 */
+	if (intel_display_wa(display, INTEL_DISPLAY_WA_14028723391) &&
+	    xe3p_lpd_fbc_fp16_format_is_valid(plane_state) &&
+	    fb->format->has_alpha) {
+		plane_state->no_fbc_reason = "Wa_14028723391";
+		return 0;
+	}
+
 	if (DISPLAY_VER(display) < 20 &&
 	    plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
 	    fb->format->has_alpha) {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-10-23 18:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-23 12:06 [PATCH] drm/i915/fbc: Apply Wa_14028723391 Vinod Govindapillai
2026-10-23 12:25 ` sashiko-bot
2026-10-23 12:49 ` ✓ CI.KUnit: success for " Patchwork
2026-10-23 13:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-23 18:40 ` ✗ Xe.CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox