From: sashiko-bot@kernel.org
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v14 01/17] drm/xe/vsec: VSEC requires soc-remapper
Date: Tue, 10 Nov 2026 18:46:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-207605@kernel.org> (raw)
In-Reply-To: <20261110183505.694124-20-michael.j.ruhl@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe/vsec: missing Fixes trailer for commit 32eab46a6160
--
commit faf5d6652027b4edb9810b0e860293174d8557a8
Author: Michael J. Ruhl <michael.j.ruhl@intel.com>
> drm/xe/vsec: VSEC requires soc-remapper
>
> Survivability mode includes xe_vsec_init(). VSEC requires
> the soc remapper to be initialized.
>
> Add the correct init to allow correct VSEC behavior.
>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
[Severity: Low]
Since 32eab46a6160 ("drm/xe/soc_remapper: Use SoC remapper helper from
VSEC code") switched xe_pmt_telem_read() to require
xe->soc_remapper.set_telem_region without initializing the SoC remapper in
enable_boot_survivability_mode(), should this include:
Fixes: 32eab46a6160 ("drm/xe/soc_remapper: Use SoC remapper helper from VSEC code")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110183505.694124-19-michael.j.ruhl@intel.com?part=1
next prev parent reply other threads:[~2026-11-10 18:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 18:35 [PATCH v14 00/17] Crescent Island PMT support Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 01/17] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
2026-11-10 18:46 ` sashiko-bot [this message]
2026-11-10 18:35 ` [PATCH v14 02/17] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 03/17] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 04/17] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-11-10 18:49 ` sashiko-bot
2026-11-10 18:35 ` [PATCH v14 05/17] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 06/17] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 07/17] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 08/17] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 09/17] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 10/17] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 11/17] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 12/17] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 13/17] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-11-10 19:08 ` sashiko-bot
2026-11-10 18:35 ` [PATCH v14 14/17] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 15/17] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 16/17] drm/xe/vsec: Refactor platform check Michael J. Ruhl
2026-11-10 18:35 ` [PATCH v14 17/17] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
2026-11-10 18:53 ` sashiko-bot
2026-11-10 18:42 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev16) Patchwork
2026-11-10 18:44 ` ✓ CI.KUnit: success " Patchwork
2026-11-10 19:20 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-10 21:19 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207605@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=michael.j.ruhl@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox