Re: [PATCH v14 04/17] drm/xe/vsec: Use correct pm state get

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe/vsec: inaccurate Fixes trailer in commit message
--

commit 59b127daa577716636b93aac167c1f0b67e5c795
Author: Michael J. Ruhl <michael.j.ruhl@intel.com>

> drm/xe/vsec: Use correct pm state get
>
> Crashlog needs to be collected at all times.  The current pm check
> assumes telemetry only.
>
> Update read path to enable device for crashlog instances.
>
> Include check of the WATCHER CAP_TYPE for completeness.
> WATCHER is a possible type and needs to be accounted for, but is not
> supported.
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Fixes: 2c402a801c19 ("platform/x86/intel/pmt: support BMG crashlog")
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

[Severity: Low]
2c402a801c19 ("platform/x86/intel/pmt: support BMG crashlog") only modified
drivers/platform/x86/intel/pmt/crashlog.c, while the unconditional
xe_pm_runtime_get_if_active() check and capability decoding in
xe_pmt_telem_read() were introduced in drivers/gpu/drm/xe/xe_vsec.c by
0c45e76fcc62 ("drm/xe/vsec: Support BMG devices").  Should the Fixes: tag
reference that commit instead:

  Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110183505.694124-19-michael.j.ruhl@intel.com?part=4