Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nareshkumar Gollakoti" <naresh.kumar.g@intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs
Date: Wed, 18 Nov 2026 14:17:11 +0000	[thread overview]
Message-ID: <sashiko-outbox-221179@kernel.org> (raw)
In-Reply-To: <20261118135536.293953-4-naresh.kumar.g@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe: unintended KernelVersion change for device_uid in sysfs
  ABI doc
--

commit 0b847a1115478ad39cc690b1b4bde83c429e6218
Author: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs

This commit exposes read-only tile#/memory/max_freq and
tile#/memory/max_bw sysfs attributes reported by PCODE MEMORY_CONFIG on
Crescent Island and documents them in the Xe sysfs ABI.

> diff --git a/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu b/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
> index 4dc4afc3961d9..13d471e0ea082 100644
> --- a/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
> +++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
> @@ -1,6 +1,6 @@
>  What:		/sys/bus/pci/drivers/xe/.../device_uid
>  Date:		October 2026
> -KernelVersion:	7.4
> +KernelVersion:	7.5
>  Contact:	intel-xe@lists.freedesktop.org

[Severity: Low]
Was the KernelVersion change on the existing device_uid entry (added in
commit "drm/xe/cri: Expose device UID through sysfs") unintended when
updating the version for the new max_bw and max_freq entries?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118135536.293953-1-naresh.kumar.g@intel.com?part=3

      reply	other threads:[~2026-11-18 14:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:55 [PATCH v2 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs Nareshkumar Gollakoti
2026-11-18 14:17   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221179@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=naresh.kumar.g@intel.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox