* [PATCH v2 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config
2026-11-18 13:55 [PATCH v2 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
@ 2026-11-18 13:55 ` Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs Nareshkumar Gollakoti
2 siblings, 0 replies; 5+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18 13:55 UTC (permalink / raw)
To: intel-xe
Cc: badal.nilawar, sk.anirban, Himal Prasad Ghimiray,
Nareshkumar Gollakoti
From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
The tile memory sysfs component is about to expose memory configuration
beyond frequency, such as maximum bandwidth. Rename xe_vram_freq.c
and xe_vram_freq.h to xe_vram_config.c xe_vram_config.h.
xe_vram_freq_sysfs_init() to xe_vram_config_sysfs_init() to reflect that.
No functional change.
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
---
drivers/gpu/drm/xe/Makefile | 2 +-
drivers/gpu/drm/xe/xe_tile_sysfs.c | 4 ++--
.../gpu/drm/xe/{xe_vram_freq.c => xe_vram_config.c} | 8 ++++----
drivers/gpu/drm/xe/xe_vram_config.h | 13 +++++++++++++
drivers/gpu/drm/xe/xe_vram_freq.h | 13 -------------
5 files changed, 20 insertions(+), 20 deletions(-)
rename drivers/gpu/drm/xe/{xe_vram_freq.c => xe_vram_config.c} (94%)
create mode 100644 drivers/gpu/drm/xe/xe_vram_config.h
delete mode 100644 drivers/gpu/drm/xe/xe_vram_freq.h
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 4377f60f5dabe..b0ce47fbac9d5 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -150,7 +150,7 @@ xe-y += xe_bb.o \
xe_vm.o \
xe_vm_madvise.o \
xe_vram.o \
- xe_vram_freq.o \
+ xe_vram_config.o \
xe_vsec.o \
xe_wa.o \
xe_wait_user_fence.o \
diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c
index 510aa0ac44287..c944579a17c85 100644
--- a/drivers/gpu/drm/xe/xe_tile_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c
@@ -10,7 +10,7 @@
#include "xe_device_types.h"
#include "xe_pm.h"
#include "xe_tile_sysfs.h"
-#include "xe_vram_freq.h"
+#include "xe_vram_config.h"
static void xe_tile_sysfs_kobj_release(struct kobject *kobj)
{
@@ -49,7 +49,7 @@ int xe_tile_sysfs_init(struct xe_tile *tile)
tile->sysfs = &kt->base;
- err = xe_vram_freq_sysfs_init(tile);
+ err = xe_vram_config_sysfs_init(tile);
if (err)
goto err_object;
diff --git a/drivers/gpu/drm/xe/xe_vram_freq.c b/drivers/gpu/drm/xe/xe_vram_config.c
similarity index 94%
rename from drivers/gpu/drm/xe/xe_vram_freq.c
rename to drivers/gpu/drm/xe/xe_vram_config.c
index 8717367ccd4c7..31a3405c39abd 100644
--- a/drivers/gpu/drm/xe/xe_vram_freq.c
+++ b/drivers/gpu/drm/xe/xe_vram_config.c
@@ -9,10 +9,10 @@
#include "xe_pcode.h"
#include "xe_pcode_api.h"
#include "xe_tile_sysfs.h"
-#include "xe_vram_freq.h"
+#include "xe_vram_config.h"
/**
- * DOC: Xe VRAM freq
+ * DOC: Xe VRAM config
*
* Provides sysfs entries for vram frequency in tile
*
@@ -93,14 +93,14 @@ static void vram_freq_sysfs_fini(void *arg)
}
/**
- * xe_vram_freq_sysfs_init - Initialize vram frequency sysfs component
+ * xe_vram_config_sysfs_init - Initialize vram configuration sysfs component
* @tile: Xe Tile object
*
* It needs to be initialized after the main tile component is ready
*
* Returns: 0 on success, negative error code on error.
*/
-int xe_vram_freq_sysfs_init(struct xe_tile *tile)
+int xe_vram_config_sysfs_init(struct xe_tile *tile)
{
struct xe_device *xe = tile_to_xe(tile);
struct kobject *kobj;
diff --git a/drivers/gpu/drm/xe/xe_vram_config.h b/drivers/gpu/drm/xe/xe_vram_config.h
new file mode 100644
index 0000000000000..98903911f6583
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_vram_config.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#ifndef _XE_VRAM_CONFIG_H_
+#define _XE_VRAM_CONFIG_H_
+
+struct xe_tile;
+
+int xe_vram_config_sysfs_init(struct xe_tile *tile);
+
+#endif /* _XE_VRAM_CONFIG_H_ */
diff --git a/drivers/gpu/drm/xe/xe_vram_freq.h b/drivers/gpu/drm/xe/xe_vram_freq.h
deleted file mode 100644
index bf726bc5881f2..0000000000000
--- a/drivers/gpu/drm/xe/xe_vram_freq.h
+++ /dev/null
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#ifndef _XE_VRAM_FREQ_H_
-#define _XE_VRAM_FREQ_H_
-
-struct xe_tile;
-
-int xe_vram_freq_sysfs_init(struct xe_tile *tile);
-
-#endif /* _XE_VRAM_FREQ_H_ */
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs
2026-11-18 13:55 [PATCH v2 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18 13:55 ` [PATCH v2 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
@ 2026-11-18 13:55 ` Nareshkumar Gollakoti
2026-11-18 14:17 ` sashiko-bot
2 siblings, 1 reply; 5+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18 13:55 UTC (permalink / raw)
To: intel-xe
Cc: badal.nilawar, sk.anirban, Himal Prasad Ghimiray,
Nareshkumar Gollakoti
From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Expose the maximum achievable memory frequency and bandwidth reported
by PCODE MEMORY_CONFIG as read-only tile#/memory/max_freq (MHz) and
tile#/memory/max_bw on Crescent Island.
These are capability limits, not the current memory frequency or
bandwidth usage. The existing PVC memory/freq0 entries are unchanged.
Document both attributes in the Xe sysfs ABI.
v2:(Sashiko)
1. Fixed CFI violation by updating attribute types and callback signatures
2. Added a check for xe->info.skip_pcode in memory_groups() to prevent
exposing these attributes on Virtual Functions,
where PCODE access is disabled.
3. Changed kernel version in documentation from 7.4 to 7.5(Badal)
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
.../ABI/testing/sysfs-driver-intel-xe-gpu | 26 +++-
drivers/gpu/drm/xe/xe_vram_config.c | 122 ++++++++++++++++--
2 files changed, 133 insertions(+), 15 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu b/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
index 4dc4afc3961d9..13d471e0ea082 100644
--- a/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
+++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
@@ -1,6 +1,6 @@
What: /sys/bus/pci/drivers/xe/.../device_uid
Date: October 2026
-KernelVersion: 7.4
+KernelVersion: 7.5
Contact: intel-xe@lists.freedesktop.org
Description:
RO. Unique 64-bit identifier of the GPU SoC device, exposed as
@@ -8,3 +8,27 @@ Description:
This sysfs file is present only on supported Intel Xe platforms.
Accessible only to users with administrative privileges.
+
+What: /sys/bus/pci/drivers/xe/.../tile<N>/memory/max_bw
+Date: October 2026
+KernelVersion: 7.5
+Contact: intel-xe@lists.freedesktop.org
+Description:
+ RO. Maximum achievable memory bandwidth reported by firmware, in
+ megabits per second (Mbps), as a decimal integer.
+ This is not a measurement of current memory bandwidth usage.
+
+ This sysfs file is present only on Crescent Island devices.
+ It is readable by all users.
+
+What: /sys/bus/pci/drivers/xe/.../tile<N>/memory/max_freq
+Date: October 2026
+KernelVersion: 7.5
+Contact: intel-xe@lists.freedesktop.org
+Description:
+ RO. Maximum achievable memory frequency reported by firmware,
+ in MHz, as a decimal integer.
+ This is not the current memory frequency.
+
+ This sysfs file is present only on Crescent Island devices.
+ It is readable by all users.
diff --git a/drivers/gpu/drm/xe/xe_vram_config.c b/drivers/gpu/drm/xe/xe_vram_config.c
index 31a3405c39abd..130a8f76e6663 100644
--- a/drivers/gpu/drm/xe/xe_vram_config.c
+++ b/drivers/gpu/drm/xe/xe_vram_config.c
@@ -8,13 +8,14 @@
#include "xe_device_types.h"
#include "xe_pcode.h"
#include "xe_pcode_api.h"
+#include "xe_pm.h"
#include "xe_tile_sysfs.h"
#include "xe_vram_config.h"
/**
* DOC: Xe VRAM config
*
- * Provides sysfs entries for vram frequency in tile
+ * Provides sysfs entries for vram frequency and bandwidth in tile
*
* device/tile#/memory/freq0/max_freq - This is maximum frequency. This value is read-only as it
* is the fixed fuse point P0. It is not the system
@@ -22,17 +23,22 @@
* device/tile#/memory/freq0/min_freq - This is minimum frequency. This value is read-only as it
* is the fixed fuse point PN. It is not the system
* configuration.
+ *
+ * On Crescent Island, the following entries are provided instead:
+ *
+ * device/tile#/memory/max_freq - Maximum achievable memory frequency in MHz. Read-only.
+ * device/tile#/memory/max_bw - Maximum achievable memory bandwidth in Mbps. Read-only.
*/
-static struct xe_tile *dev_to_tile(struct device *dev)
+static struct xe_tile *kobj_to_tile_parent(struct kobject *kobj)
{
- return kobj_to_tile(dev->kobj.parent);
+ return kobj_to_tile(kobj->parent);
}
-static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
+static ssize_t max_freq_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{
- struct xe_tile *tile = dev_to_tile(dev);
+ struct xe_tile *tile = kobj_to_tile_parent(kobj);
u32 val = 0, mbox;
int err;
@@ -49,12 +55,16 @@ static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
return sysfs_emit(buf, "%u\n", val);
}
-static DEVICE_ATTR_RO(max_freq);
-static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
+static struct kobj_attribute kobj_attr_max_freq = {
+ .attr = { .name = "max_freq", .mode = 0444 },
+ .show = max_freq_show,
+};
+
+static ssize_t min_freq_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{
- struct xe_tile *tile = dev_to_tile(dev);
+ struct xe_tile *tile = kobj_to_tile_parent(kobj);
u32 val = 0, mbox;
int err;
@@ -71,11 +81,15 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
return sysfs_emit(buf, "%u\n", val);
}
-static DEVICE_ATTR_RO(min_freq);
+
+static struct kobj_attribute kobj_attr_min_freq = {
+ .attr = { .name = "min_freq", .mode = 0444 },
+ .show = min_freq_show,
+};
static struct attribute *freq_attrs[] = {
- &dev_attr_max_freq.attr,
- &dev_attr_min_freq.attr,
+ &kobj_attr_max_freq.attr,
+ &kobj_attr_min_freq.attr,
NULL
};
@@ -84,11 +98,90 @@ static const struct attribute_group freq_group_attrs = {
.attrs = freq_attrs,
};
+static const struct attribute_group *pvc_memory_groups[] = {
+ &freq_group_attrs,
+ NULL
+};
+
+static int memory_config_read(struct kobject *kobj, u32 subcmd, u32 *val)
+{
+ struct xe_tile *tile = kobj_to_tile_parent(kobj);
+
+ guard(xe_pm_runtime)(tile_to_xe(tile));
+
+ return xe_pcode_read(tile, PCODE_MBOX(PCODE_MEMORY_CONFIG, subcmd, 0),
+ val, NULL);
+}
+
+static ssize_t cri_max_freq_show(struct kobject *kobj, struct kobj_attribute *attr,
+ char *buf)
+{
+ u32 val = 0;
+ int err;
+
+ err = memory_config_read(kobj, MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY, &val);
+ if (err)
+ return err;
+
+ return sysfs_emit(buf, "%u\n", val);
+}
+
+static struct kobj_attribute kobj_attr_cri_max_freq = {
+ .attr = { .name = "max_freq", .mode = 0444 },
+ .show = cri_max_freq_show,
+};
+
+static ssize_t max_bw_show(struct kobject *kobj, struct kobj_attribute *attr,
+ char *buf)
+{
+ u32 val = 0;
+ int err;
+
+ err = memory_config_read(kobj, MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH, &val);
+ if (err)
+ return err;
+
+ return sysfs_emit(buf, "%u\n", val);
+}
+
+static struct kobj_attribute kobj_attr_max_bw = {
+ .attr = { .name = "max_bw", .mode = 0444 },
+ .show = max_bw_show,
+};
+
+static struct attribute *cri_memory_attrs[] = {
+ &kobj_attr_cri_max_freq.attr,
+ &kobj_attr_max_bw.attr,
+ NULL
+};
+
+static const struct attribute_group cri_memory_group_attrs = {
+ .attrs = cri_memory_attrs,
+};
+
+static const struct attribute_group *cri_memory_groups[] = {
+ &cri_memory_group_attrs,
+ NULL
+};
+
+static const struct attribute_group **memory_groups(struct xe_device *xe)
+{
+ if (xe->info.skip_pcode)
+ return NULL;
+
+ if (xe->info.platform == XE_PVC)
+ return pvc_memory_groups;
+ if (xe->info.platform == XE_CRESCENTISLAND)
+ return cri_memory_groups;
+ return NULL;
+}
+
static void vram_freq_sysfs_fini(void *arg)
{
struct kobject *kobj = arg;
+ struct xe_tile *tile = kobj_to_tile(kobj->parent);
- sysfs_remove_group(kobj, &freq_group_attrs);
+ sysfs_remove_groups(kobj, memory_groups(tile_to_xe(tile)));
kobject_put(kobj);
}
@@ -103,17 +196,18 @@ static void vram_freq_sysfs_fini(void *arg)
int xe_vram_config_sysfs_init(struct xe_tile *tile)
{
struct xe_device *xe = tile_to_xe(tile);
+ const struct attribute_group **groups = memory_groups(xe);
struct kobject *kobj;
int err;
- if (xe->info.platform != XE_PVC)
+ if (!groups)
return 0;
kobj = kobject_create_and_add("memory", tile->sysfs);
if (!kobj)
return -ENOMEM;
- err = sysfs_create_group(kobj, &freq_group_attrs);
+ err = sysfs_create_groups(kobj, groups);
if (err) {
kobject_put(kobj);
return err;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread