Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/2] drm/xe/vf: New approach for post-migration LRC fixups
@ 2026-11-19 14:17 Tomasz Lis
  2026-11-19 14:17 ` [PATCH v5 1/2] drm/xe/vf: Late fixups of LRCs after VF migration Tomasz Lis
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Tomasz Lis @ 2026-11-19 14:17 UTC (permalink / raw)
  To: intel-xe
  Cc: Matthew Brost, Michał Winiarski, Piotr Piórkowski,
	Satyanarayana K V P

The current approach to LRC recovery requires caution from developers
when modifying any LRC-related code. More flexible solution may allow
to avoid future troubles.

The current code also includes LRC creation repeat which looks a bit
suspicious - it was developed without detailed knowledge of which
part of LRC creation requires a repeat. Now after extensive debug we
know that the repeat is only required for BO mapping, and actually
all BOs should be protected, not only the ones storing LRCs.

This fixes a very rare bug where BO would be incorrectly created
during migration resulting in CAT error generated by GPU. Chances
of triggering this error were well below 0.1%.

v2: A rebase after 6 months, with adjustments to current source.
v3: Re-adding a check carelessly removed in v2, fixed handling
   GGTT start/end, fixed issue with signals.
v4: Several fixes to error paths (mutex creation, and prolonged
   migration recovery while BO mapping). Altered BO insertion
   to not repeat placement in GGTT upon migration, only repeat
   the mapping.
v5: Disallow signals affecting BO insertion. Add cleanup of
   of BO mapping on recovery fail.

Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>

Tomasz Lis (2):
  drm/xe/vf: Late fixups of LRCs after VF migration
  drm/xe: After VF migration, repeat BO mapping in progress

 drivers/gpu/drm/xe/xe_exec_queue.c        | 63 +++++++++++++----------
 drivers/gpu/drm/xe/xe_exec_queue.h        |  2 +-
 drivers/gpu/drm/xe/xe_ggtt.c              | 57 +++++++++++++++++---
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c       | 23 +++++----
 drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h |  2 +
 drivers/gpu/drm/xe/xe_guc_submit.c        | 35 +++----------
 drivers/gpu/drm/xe/xe_guc_submit.h        |  2 -
 drivers/gpu/drm/xe/xe_memirq.c            | 10 +++-
 8 files changed, 114 insertions(+), 80 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-19 15:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 14:17 [PATCH v5 0/2] drm/xe/vf: New approach for post-migration LRC fixups Tomasz Lis
2026-11-19 14:17 ` [PATCH v5 1/2] drm/xe/vf: Late fixups of LRCs after VF migration Tomasz Lis
2026-11-19 14:17 ` [PATCH v5 2/2] drm/xe: After VF migration, repeat BO mapping in progress Tomasz Lis
2026-11-19 14:52   ` sashiko-bot
2026-11-19 14:58 ` ✓ CI.KUnit: success for drm/xe/vf: New approach for post-migration LRC fixups (rev5) Patchwork
2026-11-19 15:42 ` ✓ Xe.CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox