From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
Stefan Metzmacher <metze@samba.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH v1 2/2] io_uring: uapi: Don't use a zero-size array
Date: Tue, 15 Nov 2022 16:09:29 -0700 [thread overview]
Message-ID: <928d9094-db54-7b27-98a6-9ece514f12e1@kernel.dk> (raw)
In-Reply-To: <20221115212614.1308132-3-ammar.faizi@intel.com>
On 11/15/22 2:29 PM, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>
> Don't use a zero-size array because it doesn't allow the user to
> compile an app that uses liburing with the `-pedantic-errors` flag:
>
> io_uring.h:611:28: error: zero size arrays are an extension [-Werror,-Wzero-length-array]
>
> Replace the array size from 0 to 1.
>
> - No functional change is intended.
> - No struct/union size change.
The only reason why they don't grow the struct, is because it's in
a union. I don't like this patch, as the zero sized array is a clear
sign that this struct has data past it. If it's a single entry, that's
very different.
Yes that apparently makes pendantic errors unhappy, but I care more
about the readability of it.
--
Jens Axboe
next prev parent reply other threads:[~2022-11-15 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 21:29 [PATCH v1 0/2] io_uring uapi updates Ammar Faizi
2022-11-15 21:29 ` [PATCH v1 1/2] io_uring: uapi: Don't force linux/time_types.h for userspace Ammar Faizi
2022-11-15 21:29 ` [PATCH v1 2/2] io_uring: uapi: Don't use a zero-size array Ammar Faizi
2022-11-15 23:09 ` Jens Axboe [this message]
2022-11-16 10:14 ` Pavel Begunkov
2022-11-16 10:28 ` Ammar Faizi
2022-11-15 23:14 ` (subset) [PATCH v1 0/2] io_uring uapi updates Jens Axboe
2022-11-16 6:34 ` Ammar Faizi
2022-11-16 6:49 ` Ammar Faizi
2022-11-16 13:50 ` Jens Axboe
2022-11-16 14:22 ` Stefan Metzmacher
2022-11-16 19:46 ` Jens Axboe
2022-11-16 20:03 ` Stefan Metzmacher
2022-11-16 20:31 ` Pavel Begunkov
2022-11-16 20:18 ` Stefan Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=928d9094-db54-7b27-98a6-9ece514f12e1@kernel.dk \
--to=axboe@kernel.dk \
--cc=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=gwml@vger.gnuweeb.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox