From: Pavel Begunkov <asml.silence@gmail.com>
To: Bernd Schubert <bernd.schubert@fastmail.fm>, io-uring@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>, Miklos Szeredi <miklos@szeredi.hu>,
Joanne Koong <joannelkoong@gmail.com>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: Large CQE for fuse headers
Date: Fri, 11 Oct 2024 22:38:57 +0100 [thread overview]
Message-ID: <98b1e1b1-ec11-490e-b1e7-46b75d6584ee@gmail.com> (raw)
In-Reply-To: <d66377d6-9353-4a86-92cf-ccf2ea6c6a9d@fastmail.fm>
On 10/10/24 21:56, Bernd Schubert wrote:
> Hello,
>
> as discussed during LPC, we would like to have large CQE sizes, at least
> 256B. Ideally 256B for fuse, but CQE512 might be a bit too much...
>
> Pavel said that this should be ok, but it would be better to have the CQE
> size as function argument.
> Could you give me some hints how this should look like and especially how
I remembered it as SQEs, which would've been much easier. In the current
io_uring infra, usually to post a cqe an opcode specific path stashed the
result value in the request structure and then the core io_uring code will
post it for you. We won't find space for 256B, however, and it'd need to
happen right from the cmd path and follow the rules when / from what
context it can be posted.
I'll take a stub to see how it can look like.
> we are going to communicate the CQE size to the kernel? I guess just adding
> IORING_SETUP_CQE256 / IORING_SETUP_CQE512 would be much easier.
3-4 special cases is already odd as an API, we should rather just
pass the desired CQE size.
> I'm basically through with other changes Miklos had been asking for and
> moving fuse headers into the CQE is next.
--
Pavel Begunkov
next prev parent reply other threads:[~2024-10-11 21:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 20:56 Large CQE for fuse headers Bernd Schubert
2024-10-11 17:57 ` Jens Axboe
2024-10-11 18:35 ` Bernd Schubert
2024-10-11 18:39 ` Jens Axboe
2024-10-11 19:03 ` Bernd Schubert
2024-10-11 19:24 ` Jens Axboe
2024-10-11 21:38 ` Pavel Begunkov [this message]
2024-10-12 1:55 ` Ming Lei
2024-10-12 14:38 ` Jens Axboe
2024-10-13 21:20 ` Bernd Schubert
2024-10-14 2:44 ` Ming Lei
2024-10-14 11:10 ` Miklos Szeredi
2024-10-14 12:47 ` Bernd Schubert
2024-10-14 13:34 ` Pavel Begunkov
2024-10-14 15:21 ` Bernd Schubert
2024-10-14 17:48 ` Pavel Begunkov
2024-10-14 21:27 ` Bernd Schubert
2024-10-16 10:54 ` Miklos Szeredi
2024-10-16 11:53 ` Bernd Schubert
2024-10-16 12:24 ` Miklos Szeredi
2024-10-17 0:59 ` Ming Lei
2024-10-14 13:20 ` Bernd Schubert
2024-10-14 10:31 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b1e1b1-ec11-490e-b1e7-46b75d6584ee@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bernd.schubert@fastmail.fm \
--cc=io-uring@vger.kernel.org \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox