public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Kanchan Joshi <joshi.k@samsung.com>,
	hare@suse.de, sagi@grimberg.me, martin.petersen@oracle.com,
	brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
	jaegeuk@kernel.org, bcrl@kvack.org, dhowells@redhat.com,
	bvanassche@acm.org, asml.silence@gmail.com,
	linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	io-uring@vger.kernel.org, linux-block@vger.kernel.org,
	linux-aio@kvack.org, gost.dev@samsung.com, vishak.g@samsung.com,
	javier.gonz@samsung.com
Subject: Re: [PATCH v7 0/3] FDP and per-io hints
Date: Wed, 02 Oct 2024 11:47:32 -0400	[thread overview]
Message-ID: <yq17caq5xvg.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20241002151949.GA20877@lst.de> (Christoph Hellwig's message of "Wed, 2 Oct 2024 17:19:49 +0200")


Christoph,

>> Nothing prevents future improvements in that direction. It just seems
>> out of scope for what Kanchan is trying to enable for his customer use
>> cases. This patch looks harmless.
>
> It's not really.  Once we wire it up like this we mess up the ability
> to use the feature in other ways.  Additionally the per-I/O hints are
> simply broken if you want a file system

Here is my take:

It is the kernel's job to manage the system's hardware resources and
arbitrate and share these resources optimally and fairly between all
running applications.

What irks me is defining application interfaces which fundamentally tell
the kernel that "these blocks are part of the same file".

The kernel already knows this. It is the very entity which provides that
abstraction. Why do we need an explicit interface to inform the kernel
that concurrent writes to the same file should have the same
"temperature" or need to go to the same "bin" on the storage device?
Shouldn't that just happen automatically?

Whether it's SCSI groups, streams, UFS hints, or NVMe FDP, it seems like
we are consistently failing to deliver something that actually works for
anything but a few specialized corner cases. I think that is a shame.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2024-10-02 15:48 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240930182052epcas5p37edefa7556b87c3fbb543275756ac736@epcas5p3.samsung.com>
2024-09-30 18:13 ` [PATCH v7 0/3] FDP and per-io hints Kanchan Joshi
2024-09-30 18:13   ` [PATCH v7 1/3] nvme: enable FDP support Kanchan Joshi
2024-10-02 18:37     ` Bart Van Assche
2024-10-03 12:55       ` Christoph Hellwig
2024-09-30 18:13   ` [PATCH v7 2/3] block, fs: restore kiocb based write hint processing Kanchan Joshi
2024-09-30 18:13   ` [PATCH v7 3/3] io_uring: enable per-io hinting capability Kanchan Joshi
2024-10-02 14:26     ` Pavel Begunkov
2024-10-17 14:58       ` Kanchan Joshi
2024-10-02 18:29     ` Bart Van Assche
2024-10-01  9:20   ` [PATCH v7 0/3] FDP and per-io hints Christoph Hellwig
2024-10-01 15:58     ` James R. Bergsten
2024-10-01 16:18     ` Jens Axboe
2024-10-02  7:51       ` Christoph Hellwig
2024-10-02 15:03         ` Jens Axboe
2024-10-02 15:13           ` Christoph Hellwig
2024-10-02 15:17             ` Keith Busch
2024-10-02 15:19               ` Christoph Hellwig
2024-10-02 15:33                 ` Keith Busch
2024-10-03 12:51                   ` Christoph Hellwig
2024-10-02 15:47                 ` Martin K. Petersen [this message]
2024-10-02 18:34                   ` Bart Van Assche
2024-10-03 12:55                     ` Christoph Hellwig
2024-10-03 21:48                       ` Keith Busch
2024-10-03 22:00                         ` Bart Van Assche
2024-10-03 22:12                           ` Jens Axboe
2024-10-03 22:17                           ` Keith Busch
2024-10-04  6:21                       ` Javier González
2024-10-04  6:24                         ` Christoph Hellwig
2024-10-04  6:59                           ` Javier González
2024-10-04 12:32                             ` Christoph Hellwig
2024-10-07 11:29                               ` Javier González
2024-10-08 12:27                                 ` Christoph Hellwig
2024-10-03 12:54                   ` Christoph Hellwig
2024-10-03 22:14                     ` Jens Axboe
2024-10-04  5:31                       ` Christoph Hellwig
2024-10-04  6:18                         ` Javier González
2024-10-04  6:27                           ` Christoph Hellwig
2024-10-04  6:52                             ` Javier González
2024-10-04 12:30                               ` Christoph Hellwig
2024-10-07 10:10                                 ` Javier González
2024-10-08 10:06                                   ` Hans Holmberg
2024-10-09 14:36                                     ` Javier Gonzalez
2024-10-10  6:40                                       ` Hans Holmberg
2024-10-10  7:13                                         ` Javier Gonzalez
2024-10-10  9:20                                           ` Christoph Hellwig
2024-10-10 12:22                                             ` Javier Gonzalez
2024-10-11  8:56                                               ` Christoph Hellwig
2024-10-11 12:21                                                 ` Javier Gonzalez
2024-10-11 16:59                                                   ` Keith Busch
2024-10-10 10:46                                           ` Hans Holmberg
2024-10-10 12:27                                             ` Javier Gonzalez
2024-10-11  8:59                                               ` Christoph Hellwig
2024-10-08 12:25                                   ` Christoph Hellwig
2024-10-08 14:44                                     ` Keith Busch
2024-10-09  9:28                                       ` Christoph Hellwig
2024-10-09 15:06                                         ` Keith Busch
2024-10-10  7:07                                           ` Javier González
2024-10-10  9:13                                             ` Christoph Hellwig
2024-10-10 11:59                                               ` Javier González
2024-10-11  9:02                                                 ` Christoph Hellwig
2024-10-11 17:08                                                   ` Jens Axboe
2024-10-14  6:21                                                     ` Christoph Hellwig
2024-10-14  7:02                                                       ` Javier Gonzalez
2024-10-14  7:47                                                         ` Christoph Hellwig
2024-10-14  9:08                                                           ` Javier Gonzalez
2024-10-14 11:50                                                             ` Christoph Hellwig
2024-10-15  3:07                                                               ` Javier Gonzalez
2024-10-15  5:30                                                                 ` Christoph Hellwig
2024-10-10  9:10                                           ` Christoph Hellwig
2024-10-09 16:28                                         ` Nitesh Shetty
2024-10-02 15:22             ` Jens Axboe
2024-10-01 16:23     ` Keith Busch
2024-10-02  7:49       ` Christoph Hellwig
2024-10-02 14:56         ` Keith Busch
2024-10-02 15:00           ` Jens Axboe
2024-10-03  0:20   ` Bart Van Assche
2024-10-15  5:50   ` Christoph Hellwig
2024-10-15 15:09     ` Keith Busch
2024-10-15 15:22       ` Christoph Hellwig
2024-10-17 14:35     ` Kanchan Joshi
2024-10-17 15:23       ` Christoph Hellwig
2024-10-17 15:44         ` Keith Busch
2024-10-17 15:46           ` Christoph Hellwig
2024-10-17 16:06             ` Keith Busch
2024-10-17 16:15           ` Bart Van Assche
2024-10-17 16:23             ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq17caq5xvg.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=brauner@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=dhowells@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=javier.gonz@samsung.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vishak.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox