Re: [PATCH 11/11] netdev: disambiguate between disconnection types

[James Prestwood <prestwoj@gmail.com>]

On 11/14/23 12:09 PM, Denis Kenzior wrote:
> Hi James,
> 
> On 11/14/23 11:39, James Prestwood wrote:
>> Hi Denis,
>>
>> On 11/14/23 9:14 AM, Denis Kenzior wrote:
>>> There are generally three scenarios where iwd generates a disconnection
>>> command to the kernel:
>>>    1. Error conditions stemming from a connection related event.  For
>>>       example if SAE/FT/FILS authentication fails during Authenticate or
>>>       Associate steps and the kernel doesn't disconnect properly.
>>>    2. Deauthentication after the connection has been established and not
>>>       related to a connection attempt in progress.  For example, SA 
>>> Query
>>>       processing that triggers an disconnect.
>>>    3. Disconnects that are triggered due to a handshake failure or if
>>>       setting keys resulting from the handshake fails.  These 
>>> disconnects
>>>       can be triggered as a result of a pending connection or when a
>>>       connection has been established (e.g. due to rekeying).
>>>
>>> Distinguish between 1 and 2/3 by having the disconnect procedure take
>>> different paths.  For now there are no functional changes since all
>>> paths end up in netdev_connect_failed(), but this will change in the
>>> future.
>>
>> I'm guessing the future changes would be to handle a CMD_DISCONNECT 
>> event via the connect callback?
> 
> Possibly.  Have not made up my mind completely yet, but we do it both 
> ways right now and we need to stick to one.  Wanted to get the easy 
> stuff out of the way first.  Any comments or should I push this out?

Nope, it looks good to me.

> 
> Regards,
> -Denis
>