public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 11/11] netdev: disambiguate between disconnection types
Date: Tue, 14 Nov 2023 09:39:08 -0800	[thread overview]
Message-ID: <a9b81f8e-a0d4-4b1d-9afb-a33cf9d27767@gmail.com> (raw)
In-Reply-To: <20231114171455.1108856-11-denkenz@gmail.com>

Hi Denis,

On 11/14/23 9:14 AM, Denis Kenzior wrote:
> There are generally three scenarios where iwd generates a disconnection
> command to the kernel:
>    1. Error conditions stemming from a connection related event.  For
>       example if SAE/FT/FILS authentication fails during Authenticate or
>       Associate steps and the kernel doesn't disconnect properly.
>    2. Deauthentication after the connection has been established and not
>       related to a connection attempt in progress.  For example, SA Query
>       processing that triggers an disconnect.
>    3. Disconnects that are triggered due to a handshake failure or if
>       setting keys resulting from the handshake fails.  These disconnects
>       can be triggered as a result of a pending connection or when a
>       connection has been established (e.g. due to rekeying).
> 
> Distinguish between 1 and 2/3 by having the disconnect procedure take
> different paths.  For now there are no functional changes since all
> paths end up in netdev_connect_failed(), but this will change in the
> future.

I'm guessing the future changes would be to handle a CMD_DISCONNECT 
event via the connect callback?

Thanks,
James

  reply	other threads:[~2023-11-14 17:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 17:14 [PATCH 01/11] netdev: Fix obtaining reason code from deauth frames Denis Kenzior
2023-11-14 17:14 ` [PATCH 02/11] netdev: sa_query: Fix reason code handling Denis Kenzior
2023-11-14 17:14 ` [PATCH 03/11] netdev: Use CMD_DISCONNECT if OCI fails Denis Kenzior
2023-11-14 17:14 ` [PATCH 04/11] netdev: Don't unnecessarily call netdev_connect_failed Denis Kenzior
2023-11-14 17:14 ` [PATCH 05/11] netdev: Move CMD_DISCONNECT builder to nl80211util Denis Kenzior
2023-11-14 17:14 ` [PATCH 06/11] netdev: Move CMD_DEAUTHENTICATE " Denis Kenzior
2023-11-14 17:14 ` [PATCH 07/11] netdev: Move CMD_DEL_STATION " Denis Kenzior
2023-11-14 17:14 ` [PATCH 08/11] netdev: Move pairwise NEW_KEY " Denis Kenzior
2023-11-14 17:14 ` [PATCH 09/11] netdev: Move CMD_NEW_KEY RX-only " Denis Kenzior
2023-11-14 17:14 ` [PATCH 10/11] netdev: Move CMD_REKEY_OFFLOAD " Denis Kenzior
2023-11-14 17:14 ` [PATCH 11/11] netdev: disambiguate between disconnection types Denis Kenzior
2023-11-14 17:39   ` James Prestwood [this message]
2023-11-14 20:09     ` Denis Kenzior
2023-11-14 20:11       ` James Prestwood
2023-11-24 12:20   ` Alvin Šipraga
2023-11-24 16:25     ` Denis Kenzior
2023-11-25 20:57       ` Alvin Šipraga
2023-11-14 20:48 ` [PATCH 01/11] netdev: Fix obtaining reason code from deauth frames Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9b81f8e-a0d4-4b1d-9afb-a33cf9d27767@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox