Re: [PATCH 3/3] client: add client commands for shared code configuration

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

On 11/9/23 12:49, James Prestwood wrote:
> The StartConfigurator() call was left out since there would be no
> functional difference to the user in iwctl. Its expected that
> human users of the shared code API provide the code/id ahead of
> time, i.e. use ConfigureEnrollee/StartEnrollee.
> ---
>   Makefile.am       |   3 +-
>   client/dpp-pkex.c | 342 ++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 344 insertions(+), 1 deletion(-)
>   create mode 100644 client/dpp-pkex.c
> 

<snip>

> diff --git a/client/dpp-pkex.c b/client/dpp-pkex.c
> new file mode 100644
> index 00000000..7a6934e1
> --- /dev/null
> +++ b/client/dpp-pkex.c
> @@ -0,0 +1,342 @@
> +/*
> + *
> + *  Wireless daemon for Linux
> + *
> + *  Copyright (C) 2023  Intel Corporation. All rights reserved.
> + *

This looks incorrect.  Copy-paste?

> + *  This library is free software; you can redistribute it and/or
> + *  modify it under the terms of the GNU Lesser General Public
> + *  License as published by the Free Software Foundation; either
> + *  version 2.1 of the License, or (at your option) any later version.
> + *
> + *  This library is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + *  Lesser General Public License for more details.
> + *
> + *  You should have received a copy of the GNU Lesser General Public
> + *  License along with this library; if not, write to the Free Software
> + *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> + *
> + */
> +
<snip>

> +static enum cmd_status cmd_enroll_or_configure(const char *device_name,
> +						char **argv, int argc,
> +						const char *method)
> +{
> +	struct l_dbus_message_builder *builder;
> +	const struct proxy_interface *pkex;
> +	const char *key;
> +	const char *id = NULL;
> +
> +	pkex = device_proxy_find(device_name, IWD_DPP_PKEX_INTERFACE);
> +	if (!pkex) {
> +		display("No pkex pkex on device: '%s'\n", device_name);
> +		return CMD_STATUS_INVALID_VALUE;
> +	}
> +
> +	if (argc < 1)
> +		return CMD_STATUS_INVALID_ARGS;
> +
> +	key = argv[0];
> +
> +	if (argc > 1)
> +		id = argv[1];
> +
> +	builder = proxy_interface_new_builder(pkex, method);
> +
> +	l_dbus_message_builder_enter_array(builder, "{sv}");
> +
> +	append_dict_basic(builder, "Code", 's', key);
> +
> +	if (id)
> +		append_dict_basic(builder, "Identifier", 's', id);
> +
> +	l_dbus_message_builder_leave_array(builder);

This can all be done as:

l_dbus_message_set_arguments(msg, "a{sv}", 2,
				"Code", "s", key,
				"Identifier", "s", id);

> +
> +	proxy_interface_method_call_from_builder(pkex, builder,
> +						check_errors_method_callback);
> +	l_dbus_message_builder_destroy(builder);
> +
> +	return CMD_STATUS_TRIGGERED;
> +}
> +

Regards,
-Denis