Re: [PATCH 2/3] client: add helper to call method via builder

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

On 11/9/23 12:49, James Prestwood wrote:
> There was no way to call a method with anything except basic
> arguments. Add a helper to use a builder to create more complex
> args.
> ---
>   client/dbus-proxy.c | 36 +++++++++++++++++++++++++++++++++++-
>   client/dbus-proxy.h |  9 +++++++++
>   2 files changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/client/dbus-proxy.c b/client/dbus-proxy.c
> index 42b8427f..de252427 100644
> --- a/client/dbus-proxy.c
> +++ b/client/dbus-proxy.c
> @@ -2,7 +2,7 @@
>    *
>    *  Wireless daemon for Linux
>    *
> - *  Copyright (C) 2017-2020  Intel Corporation. All rights reserved.
> + *  Copyright (C) 2017-2023  Intel Corporation. All rights reserved.

Is this correct?

>    *
>    *  This library is free software; you can redistribute it and/or
>    *  modify it under the terms of the GNU Lesser General Public
> @@ -629,6 +629,40 @@ bool proxy_interface_method_call(const struct proxy_interface *proxy,
>   	return true;
>   }
>   
> +struct l_dbus_message_builder *proxy_interface_new_builder(
> +				const struct proxy_interface *proxy,
> +				const char *name)
> +{
> +	struct l_dbus_message *call = l_dbus_message_new_method_call(dbus,
> +						IWD_SERVICE, proxy->path,
> +						proxy->type->interface, name);
> +
> +	return l_dbus_message_builder_new(call);

Do you really need this 2 line function for a single call site?

> +}
> +
> +bool proxy_interface_method_call_from_builder(
> +					const struct proxy_interface *proxy,
> +					struct l_dbus_message_builder *builder,
> +					l_dbus_message_func_t callback)
> +{
> +	struct proxy_callback_data *callback_data;
> +	struct l_dbus_message *call;
> +
> +	if (!proxy || !builder)
> +		return false;
> +
> +	call = l_dbus_message_builder_finalize(builder);
> +
> +	callback_data = l_new(struct proxy_callback_data, 1);
> +	callback_data->callback = callback;
> +	callback_data->user_data = (void *) proxy;
> +
> +	l_dbus_send_with_reply(dbus, call, proxy_callback, callback_data,
> +									l_free);
> +
> +	return true;
> +}
> +
>   void *proxy_interface_get_data(const struct proxy_interface *proxy)
>   {
>   	return proxy->data;

Regards,
-Denis