From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 2/4] test-runner: fix crash for tests using radius_server
Date: Mon, 16 Mar 2020 12:22:40 -0700 [thread overview]
Message-ID: <20200316192242.15588-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20200316192242.15588-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
Tests which use a standalone RADIUS server may crash due to
the wiphy array not taking into account the 'radius_server'
key which is skipped during setup.
---
tools/test-runner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/test-runner.c b/tools/test-runner.c
index 42bd60e2..1f0bc4dd 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -1373,7 +1373,7 @@ static bool configure_hostapd_instances(struct l_settings *hw_settings,
hostapd_config_file_paths = l_new(char *, i + 1);
wiphys = alloca(sizeof(struct wiphy *) * (i + 1));
- wiphys[i] = NULL;
+ memset(wiphys, 0, sizeof(struct wiphy *) * (i + 1));
hostapd_pids_out[0] = -1;
--
2.21.1
next prev parent reply other threads:[~2020-03-16 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 19:22 [PATCH 1/4] test-runner: fix crash if ofono is not installed James Prestwood
2020-03-16 19:22 ` James Prestwood [this message]
2020-03-16 19:22 ` [PATCH 3/4] test-runner: fix improper loading of radius_config James Prestwood
2020-03-16 19:22 ` [PATCH 4/4] netdev: fix auth protocols not setting ->connected James Prestwood
2020-03-16 20:22 ` [PATCH 1/4] test-runner: fix crash if ofono is not installed Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316192242.15588-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox