From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 4/4] netdev: fix auth protocols not setting ->connected
Date: Mon, 16 Mar 2020 12:22:42 -0700 [thread overview]
Message-ID: <20200316192242.15588-4-prestwoj@gmail.com> (raw)
In-Reply-To: <20200316192242.15588-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
This causes netdev to think another supplicant is running when it
recieves a connect event due to an auth protocol running.
---
src/netdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/netdev.c b/src/netdev.c
index a5071471..c11a483f 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -2413,7 +2413,9 @@ static int netdev_connect_common(struct netdev *netdev,
NL80211_EXT_FEATURE_CAN_REPLACE_PTK0))
handshake_state_set_no_rekey(hs, true);
- auth_proto_start(netdev->ap);
+ /* set connected since the auth protocols cannot do so internally */
+ if (netdev->ap && auth_proto_start(netdev->ap))
+ netdev->connected = true;
return 0;
}
--
2.21.1
next prev parent reply other threads:[~2020-03-16 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 19:22 [PATCH 1/4] test-runner: fix crash if ofono is not installed James Prestwood
2020-03-16 19:22 ` [PATCH 2/4] test-runner: fix crash for tests using radius_server James Prestwood
2020-03-16 19:22 ` [PATCH 3/4] test-runner: fix improper loading of radius_config James Prestwood
2020-03-16 19:22 ` James Prestwood [this message]
2020-03-16 20:22 ` [PATCH 1/4] test-runner: fix crash if ofono is not installed Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316192242.15588-4-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox