From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH] netdev: don't include ATTR_IE for SAE
Date: Thu, 07 May 2020 12:34:46 -0700 [thread overview]
Message-ID: <20200507193446.8975-1-prestwoj@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
The spec outlines what fields/elements can be included with different
auth types. For SAE only a few fields are allowed. IE's are not allowed
but were being included with CMD_AUTHENTICATE.
---
src/netdev.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/netdev.c b/src/netdev.c
index b3c3bf73..bce6ada3 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -2143,7 +2143,15 @@ static struct l_genl_msg *netdev_build_cmd_authenticate(struct netdev *netdev,
l_genl_msg_append_attr(msg, NL80211_ATTR_SSID, hs->ssid_len, hs->ssid);
l_genl_msg_append_attr(msg, NL80211_ATTR_AUTH_TYPE, 4, &auth_type);
- l_genl_msg_append_attr(msg, NL80211_ATTR_IE, hs->supplicant_ie[1] + 2,
+ /*
+ * IEEE 802.11-2016 Table 9-36 Presents of fields in Auth frames
+ *
+ * For the SAE auth type no IEs are listed to be included in the
+ * authenticate frame. Only SAE related fields should be included.
+ */
+ if (auth_type != NL80211_AUTHTYPE_SAE)
+ l_genl_msg_append_attr(msg, NL80211_ATTR_IE,
+ hs->supplicant_ie[1] + 2,
hs->supplicant_ie);
return msg;
--
2.21.1
reply other threads:[~2020-05-07 19:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507193446.8975-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox