Wireless Daemon for Linux
 help / color / mirror / Atom feed
* [PATCH] netdev: don't include ATTR_IE for SAE
@ 2020-05-07 19:34 James Prestwood
  0 siblings, 0 replies; only message in thread
From: James Prestwood @ 2020-05-07 19:34 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

The spec outlines what fields/elements can be included with different
auth types. For SAE only a few fields are allowed. IE's are not allowed
but were being included with CMD_AUTHENTICATE.
---
 src/netdev.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/netdev.c b/src/netdev.c
index b3c3bf73..bce6ada3 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -2143,7 +2143,15 @@ static struct l_genl_msg *netdev_build_cmd_authenticate(struct netdev *netdev,
 	l_genl_msg_append_attr(msg, NL80211_ATTR_SSID, hs->ssid_len, hs->ssid);
 	l_genl_msg_append_attr(msg, NL80211_ATTR_AUTH_TYPE, 4, &auth_type);
 
-	l_genl_msg_append_attr(msg, NL80211_ATTR_IE, hs->supplicant_ie[1] + 2,
+	/*
+	 * IEEE 802.11-2016 Table 9-36 Presents of fields in Auth frames
+	 *
+	 * For the SAE auth type no IEs are listed to be included in the
+	 * authenticate frame. Only SAE related fields should be included.
+	 */
+	if (auth_type != NL80211_AUTHTYPE_SAE)
+		l_genl_msg_append_attr(msg, NL80211_ATTR_IE,
+					hs->supplicant_ie[1] + 2,
 					hs->supplicant_ie);
 
 	return msg;
-- 
2.21.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-07 19:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 19:34 [PATCH] netdev: don't include ATTR_IE for SAE James Prestwood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox