From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH v2 13/15] auto-t: remove device.wait_for_connected
Date: Fri, 28 Aug 2020 09:40:48 -0700 [thread overview]
Message-ID: <20200828164050.1456-14-prestwoj@gmail.com> (raw)
In-Reply-To: <20200828164050.1456-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2328 bytes --]
I had added this without realizing wait_for_object_condition
can do this already using the device object.
---
autotests/testSAE/clogging_test.py | 3 ++-
autotests/util/iwd.py | 25 -------------------------
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/autotests/testSAE/clogging_test.py b/autotests/testSAE/clogging_test.py
index e94e2ad6..c46c5821 100644
--- a/autotests/testSAE/clogging_test.py
+++ b/autotests/testSAE/clogging_test.py
@@ -48,7 +48,8 @@ class Test(unittest.TestCase):
wd.wait_for_object_condition(n.network_object, condition)
for d in devices:
- d.wait_for_connected()
+ condition = 'obj.state == DeviceState.connected'
+ wd.wait_for_object_condition(d, condition)
for d in devices:
d.disconnect()
diff --git a/autotests/util/iwd.py b/autotests/util/iwd.py
index 113039b6..9c106b89 100755
--- a/autotests/util/iwd.py
+++ b/autotests/util/iwd.py
@@ -568,31 +568,6 @@ class Device(IWDDBusAbstract):
if self._adhoc_timed_out:
raise TimeoutError("Timed out waiting for peer %s" % addr)
- def wait_for_connected(self):
- if str(self.state) == "connected":
- return
-
- self._connected_success = False
- self._connected_timed_out = False
-
- def wait_timeout_cb():
- self._connected_timed_out = True
- return False
-
- def connected_prop_changed(iface, changed, invalid):
- if changed.get('State', None):
- if changed['State'] == 'connected':
- self._connected_success = True
-
- self._prop_proxy.connect_to_signal('PropertiesChanged',
- connected_prop_changed)
- GLib.timeout_add(int(15 * 1000), wait_timeout_cb)
- context = mainloop.get_context()
- while not self._connected_success:
- context.iteration(may_block=True)
- if self._connected_timed_out:
- raise TimeoutError("Timed out waiting for connected")
-
def __str__(self, prefix = ''):
return prefix + 'Device: ' + self.device_path + '\n'\
+ prefix + '\tName:\t\t' + self.name + '\n'\
--
2.21.1
next prev parent reply other threads:[~2020-08-28 16:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 16:40 [PATCH v2 00/15] Test Runner rewrite James Prestwood
2020-08-28 16:40 ` [PATCH v2 01/15] auto-t: prepare autotests for test-runner re-write James Prestwood
2020-08-28 16:40 ` [PATCH v2 02/15] auto-t: introduce pure python " James Prestwood
2020-08-28 16:40 ` [PATCH v2 03/15] auto-t: hostapd.py: update to work with test-runner rewrite James Prestwood
2020-08-28 16:40 ` [PATCH v2 04/15] auto-t: testutil.py: " James Prestwood
2020-08-28 16:40 ` [PATCH v2 05/15] auto-t: ofono.py: fix timeout cleanup and wait for service James Prestwood
2020-08-28 16:40 ` [PATCH v2 06/15] auto-t: iwd.py: update to work with test-runner rewrite James Prestwood
2020-08-28 16:40 ` [PATCH v2 07/15] auto-t: iwd.py: fix multiple timeout cleanup issues James Prestwood
2020-08-28 16:40 ` [PATCH v2 08/15] auto-t: remove wiphy.py James Prestwood
2020-08-28 16:40 ` [PATCH v2 09/15] auto-t: fix hidden network test James Prestwood
2020-08-28 16:40 ` [PATCH v2 10/15] auto-t: fix testSAE autoconnect_test.py James Prestwood
2020-08-28 16:40 ` [PATCH v2 11/15] auto-t: skip ofono tests if ofonod isn't running James Prestwood
2020-08-28 16:40 ` [PATCH v2 12/15] auto-t: replace hard-coded interfaces James Prestwood
2020-08-28 16:40 ` James Prestwood [this message]
2020-08-28 16:40 ` [PATCH v2 14/15] tools: post test-runner rewrite cleanup James Prestwood
2020-08-28 16:40 ` [PATCH v2 15/15] doc: update test runner docs James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828164050.1456-14-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox