Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: Neehar Vijay <env252525@gmail.com>
To: iwd@lists.linux.dev
Cc: Neehar Vijay <env252525@gmail.com>
Subject: [PATCH 3/3] client: fix non-interactive mode in some cases
Date: Sun, 20 Nov 2022 21:39:17 +0530	[thread overview]
Message-ID: <20221120160912.72307-3-env252525@gmail.com> (raw)
In-Reply-To: <20221120160912.72307-1-env252525@gmail.com>

Before this change, I noticed that some non-interactive commands
don't work,

  $ iwctl version

  $ iwctl help

while other ones do.

  $ iwctl station wlan0 show

This seems to be a typo bug in the if clause checking for additional
arguments.
---
 client/command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/command.c b/client/command.c
index dbd97703..84be680c 100644
--- a/client/command.c
+++ b/client/command.c
@@ -753,7 +753,7 @@ options_parsed:
 	argv += optind;
 	argc -= optind;
 
-	if (argc < 2) {
+	if (argc < 1) {
 		interactive_mode = true;
 		return false;
 	}
-- 
2.38.1


  parent reply	other threads:[~2022-11-20 16:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20 16:09 [PATCH 1/3] gitignore: add compile_commands.json Neehar Vijay
2022-11-20 16:09 ` [PATCH 2/3] gitignore: add .ccls-cache Neehar Vijay
2022-11-20 16:09 ` Neehar Vijay [this message]
2022-11-22 17:20 ` [PATCH 1/3] gitignore: add compile_commands.json Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221120160912.72307-3-env252525@gmail.com \
    --to=env252525@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox