[PATCH 1/3] gitignore: add compile_commands.json

[PATCH 1/3] gitignore: add compile_commands.json

[Neehar Vijay]

This file is a compilation command database used by clangd and ccls,
and can be generated by tools like https://github.com/rizsotto/Bear.

  $ bear -- make clean all
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 61b3638d..f215701d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,7 @@
 .deps
 .dirstamp
 .cache
+compile_commands.json
 tags
 cscope.*
 Makefile
-- 
2.38.1

[PATCH 2/3] gitignore: add .ccls-cache

[Neehar Vijay]

This directory is used by ccls.
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index f215701d..bc429883 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,7 @@
 .deps
 .dirstamp
 .cache
+.ccls-cache
 compile_commands.json
 tags
 cscope.*
-- 
2.38.1

[PATCH 3/3] client: fix non-interactive mode in some cases

[Neehar Vijay]

Before this change, I noticed that some non-interactive commands
don't work,

  $ iwctl version

  $ iwctl help

while other ones do.

  $ iwctl station wlan0 show

This seems to be a typo bug in the if clause checking for additional
arguments.
---
 client/command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/command.c b/client/command.c
index dbd97703..84be680c 100644
--- a/client/command.c
+++ b/client/command.c
@@ -753,7 +753,7 @@ options_parsed:
 	argv += optind;
 	argc -= optind;
 
-	if (argc < 2) {
+	if (argc < 1) {
 		interactive_mode = true;
 		return false;
 	}
-- 
2.38.1

Re: [PATCH 1/3] gitignore: add compile_commands.json

[Denis Kenzior]

Hi Neehar,

On 11/20/22 10:09, Neehar Vijay wrote:
> This file is a compilation command database used by clangd and ccls,
> and can be generated by tools like https://github.com/rizsotto/Bear.
> 
>    $ bear -- make clean all
> ---
>   .gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 

All applied, thanks.

Regards,
-Denis