* [PATCH] unit: correct memcpy overrun in test-dpp
@ 2023-10-25 22:42 James Prestwood
2023-10-26 14:33 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2023-10-25 22:42 UTC (permalink / raw)
To: iwd; +Cc: James Prestwood
The memcpy in HEX2BUF was copying the length of the buffer that was
passed in, not the actual length of the converted hexstring. This
test was segfaulting in the Alpine CI which uses clang/musl.
---
unit/test-dpp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/unit/test-dpp.c b/unit/test-dpp.c
index c782efba..c3f3731f 100644
--- a/unit/test-dpp.c
+++ b/unit/test-dpp.c
@@ -183,8 +183,9 @@ const char *r_asn1 = "3039301306072a8648ce3d020106082a8648ce3d0301070322000209c5
"4df9fd25a045201885c39cc5cfae397ddaeda957dec57fa0e3503f";
#define HEX2BUF(s, buf, _len) { \
- unsigned char *_tmp = l_util_from_hexstring(s, NULL); \
- memcpy(buf, _tmp, _len); \
+ size_t _len_out; \
+ unsigned char *_tmp = l_util_from_hexstring(s, &_len_out); \
+ memcpy(buf, _tmp, _len_out); \
l_free(_tmp); \
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-26 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 22:42 [PATCH] unit: correct memcpy overrun in test-dpp James Prestwood
2023-10-26 14:33 ` Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox