Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH] dpp: fix removed dpp_reset in Stop()
Date: Thu,  9 Nov 2023 09:25:22 -0800	[thread overview]
Message-ID: <20231109172522.37912-1-prestwoj@gmail.com> (raw)

It seems in my patch reordering both stop methods lost the actual
call to dpp_reset().
---
 src/dpp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/dpp.c b/src/dpp.c
index a0c44eda..9501f3de 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -3961,9 +3961,13 @@ static struct l_dbus_message *dpp_dbus_stop(struct l_dbus *dbus,
 {
 	struct dpp_sm *dpp = user_data;
 
+	l_debug("");
+
 	if (dpp->interface != DPP_INTERFACE_DPP)
 		return dbus_error_not_found(message);
 
+	dpp_reset(dpp);
+
 	return l_dbus_message_new_method_return(message);
 }
 
@@ -4340,9 +4344,13 @@ static struct l_dbus_message *dpp_dbus_pkex_stop(struct l_dbus *dbus,
 {
 	struct dpp_sm *dpp = user_data;
 
+	l_debug("");
+
 	if (dpp->interface != DPP_INTERFACE_PKEX)
 		return dbus_error_not_found(message);
 
+	dpp_reset(dpp);
+
 	return l_dbus_message_new_method_return(message);
 }
 
-- 
2.25.1


             reply	other threads:[~2023-11-09 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 17:25 James Prestwood [this message]
2023-11-10  2:16 ` [PATCH] dpp: fix removed dpp_reset in Stop() Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109172522.37912-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox