* [PATCH] dpp: fix removed dpp_reset in Stop()
@ 2023-11-09 17:25 James Prestwood
2023-11-10 2:16 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2023-11-09 17:25 UTC (permalink / raw)
To: iwd; +Cc: James Prestwood
It seems in my patch reordering both stop methods lost the actual
call to dpp_reset().
---
src/dpp.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/dpp.c b/src/dpp.c
index a0c44eda..9501f3de 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -3961,9 +3961,13 @@ static struct l_dbus_message *dpp_dbus_stop(struct l_dbus *dbus,
{
struct dpp_sm *dpp = user_data;
+ l_debug("");
+
if (dpp->interface != DPP_INTERFACE_DPP)
return dbus_error_not_found(message);
+ dpp_reset(dpp);
+
return l_dbus_message_new_method_return(message);
}
@@ -4340,9 +4344,13 @@ static struct l_dbus_message *dpp_dbus_pkex_stop(struct l_dbus *dbus,
{
struct dpp_sm *dpp = user_data;
+ l_debug("");
+
if (dpp->interface != DPP_INTERFACE_PKEX)
return dbus_error_not_found(message);
+ dpp_reset(dpp);
+
return l_dbus_message_new_method_return(message);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dpp: fix removed dpp_reset in Stop()
2023-11-09 17:25 [PATCH] dpp: fix removed dpp_reset in Stop() James Prestwood
@ 2023-11-10 2:16 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2023-11-10 2:16 UTC (permalink / raw)
To: James Prestwood, iwd
Hi James,
On 11/9/23 11:25, James Prestwood wrote:
> It seems in my patch reordering both stop methods lost the actual
> call to dpp_reset().
In the future, lets use the Fixes: tag for commits like this.
> ---
> src/dpp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-10 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-09 17:25 [PATCH] dpp: fix removed dpp_reset in Stop() James Prestwood
2023-11-10 2:16 ` Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox