[PATCH 1/2] dpp: fail early if multicast frame registration is unsupported

[PATCH 1/2] dpp: fail early if multicast frame registration is unsupported

[James Prestwood]

This is done already for DPP, do the same for PKEX. Few drivers
(ath9k upstream, ath10k/11k in progress) support this which is
unfortunate but since a configurator will not work without this
capability its best to fail early.
---
 src/dpp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/dpp.c b/src/dpp.c
index 0064187b..c7cd4bb3 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -4362,6 +4362,12 @@ static struct l_dbus_message *dpp_start_pkex_configurator(struct dpp_sm *dpp,
 				dpp->interface != DPP_INTERFACE_UNBOUND)
 		return dbus_error_busy(message);
 
+	if (!dpp->mcast_support) {
+		l_debug("Multicast frame registration not supported, cannot "
+			"start a configurator");
+		return dbus_error_not_supported(message);
+	}
+
 	if (!network || !bss)
 		return dbus_error_not_connected(message);
 
-- 
2.34.1

[PATCH 2/2] doc: document additional NotSupported shared code return

[James Prestwood]

---
 doc/device-provisioning-api.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/device-provisioning-api.txt b/doc/device-provisioning-api.txt
index 9994aef5..6cf16fb8 100644
--- a/doc/device-provisioning-api.txt
+++ b/doc/device-provisioning-api.txt
@@ -109,6 +109,7 @@ Object path	/net/connman/iwd/{phy0,phy1,...}/{1,2,...}
 			Possible errors:	net.connman.iwd.Busy
 						net.connman.iwd.NotConnected
 						net.connman.InvalidArguments
+						net.connman.NotSupported
 
 		void StartEnrollee(a{sv})
 
@@ -156,6 +157,7 @@ Object path	/net/connman/iwd/{phy0,phy1,...}/{1,2,...}
 			Possible errors:	net.connman.iwd.Busy
 						net.connman.iwd.NotConnected
 						net.connman.iwd.NoAgent
+						net.connman.iwd.NotSupported
 
 		Stop()
 
-- 
2.34.1

Re: [PATCH 1/2] dpp: fail early if multicast frame registration is unsupported

[Denis Kenzior]

Hi James,

On 11/17/23 10:00, James Prestwood wrote:
> This is done already for DPP, do the same for PKEX. Few drivers
> (ath9k upstream, ath10k/11k in progress) support this which is
> unfortunate but since a configurator will not work without this
> capability its best to fail early.
> ---
>   src/dpp.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 

Both applied, thanks.

Regards,
-Denis