public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] build: make missing rst2man non-fatal
@ 2024-01-05 16:47 James Prestwood
  0 siblings, 0 replies; only message in thread
From: James Prestwood @ 2024-01-05 16:47 UTC (permalink / raw)
  To: iwd; +Cc: James Prestwood

The configure.ac script does not fail to configure if rst2man is missing
but instead sets RUN_RST2MAN depending on if its available, i.e. makes
it an optional requirement. But then in Makefile.am if RUN_RST2MAN is
not set it fails fatally and will not continue with the build.

Instead remove the false return so the build can continue. Another
option would be to put a hard requirement on rst2man and not allow
configure to proceed, but based on the existing logic it did not seem
like this was the original intent.
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index b634b730..c8a59f50 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -725,7 +725,7 @@ RST2MAN_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
 			--no-generator --no-datestamp $< $@
 else
 RST2MAN_PROCESS = $(AM_V_GEN)test -f $@ || \
-		{ echo "Generated manual page $@ does not exist"; false; }
+		{ echo "Generated manual page $@ does not exist"; }
 endif
 
 %.service: %.service.in Makefile
-- 
2.34.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2024-01-05 16:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-05 16:47 [PATCH] build: make missing rst2man non-fatal James Prestwood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox