From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 2/2] station: warn on missing scan_bss in station_transition_start
Date: Tue, 27 Feb 2024 13:16:18 -0800 [thread overview]
Message-ID: <20240227211618.318442-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20240227211618.318442-1-prestwoj@gmail.com>
This shouldn't be possible in theory since the roam_bss_list being
iterated is a subset of entire scan_bss list station/network has
but to be safe, and catch any issues due to future changes warn on
this condition.
---
src/station.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/station.c b/src/station.c
index 477f444a..641068cc 100644
--- a/src/station.c
+++ b/src/station.c
@@ -2533,6 +2533,8 @@ static void station_transition_start(struct station *station)
while ((rbss = l_queue_peek_head(station->roam_bss_list))) {
struct scan_bss *bss = network_bss_find_by_addr(
station->connected_network, rbss->addr);
+ if (L_WARN_ON(!bss))
+ continue;
roaming = station_try_next_transition(station, bss,
rbss->ft_failed);
--
2.34.1
next prev parent reply other threads:[~2024-02-27 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:16 [PATCH 1/2] crypto: fix uninitialized variable coverity warning James Prestwood
2024-02-27 21:16 ` James Prestwood [this message]
2024-02-27 22:03 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227211618.318442-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox