[PATCH 1/2] crypto: fix uninitialized variable coverity warning

[PATCH 1/2] crypto: fix uninitialized variable coverity warning

[James Prestwood]

Same as for aes_siv_decrypt, check num_ads before calling memcpy.
---
 src/crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/crypto.c b/src/crypto.c
index 7235e3c2..15a7cde7 100644
--- a/src/crypto.c
+++ b/src/crypto.c
@@ -390,7 +390,7 @@ bool aes_siv_decrypt(const void *key, size_t key_len, const void *in,
 	if (in_len < 16)
 		return false;
 
-	if (ad)
+	if (ad && num_ad)
 		memcpy(iov, ad, sizeof(struct iovec) * num_ad);
 
 	iov[num_ad].iov_base = (void *)out;
-- 
2.34.1

[PATCH 2/2] station: warn on missing scan_bss in station_transition_start

[James Prestwood]

This shouldn't be possible in theory since the roam_bss_list being
iterated is a subset of entire scan_bss list station/network has
but to be safe, and catch any issues due to future changes warn on
this condition.
---
 src/station.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/station.c b/src/station.c
index 477f444a..641068cc 100644
--- a/src/station.c
+++ b/src/station.c
@@ -2533,6 +2533,8 @@ static void station_transition_start(struct station *station)
 	while ((rbss = l_queue_peek_head(station->roam_bss_list))) {
 		struct scan_bss *bss = network_bss_find_by_addr(
 					station->connected_network, rbss->addr);
+		if (L_WARN_ON(!bss))
+			continue;
 
 		roaming = station_try_next_transition(station, bss,
 							rbss->ft_failed);
-- 
2.34.1

Re: [PATCH 1/2] crypto: fix uninitialized variable coverity warning

[Denis Kenzior]

Hi James,

On 2/27/24 15:16, James Prestwood wrote:
> Same as for aes_siv_decrypt, check num_ads before calling memcpy.
> ---
>   src/crypto.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Both applied, thanks.

Regards,
-Denis