Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 2/3] scan: replace -ENETUNREACH with -ENOTSUP for rate estimation return
Date: Mon, 15 Apr 2024 08:11:29 -0700	[thread overview]
Message-ID: <20240415151130.40389-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20240415151130.40389-1-prestwoj@gmail.com>

The rate estimation functions now just return 0 or -ENOTSUP for
success or if no estimation could be made due to missing IEs. Only
in the case of other errors (such as malformed IEs) should a
warning be printed.
---
 src/scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/scan.c b/src/scan.c
index f48ffdef..a22cc27a 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -1608,7 +1608,7 @@ static struct scan_bss *scan_parse_attr_bss(struct l_genl_attr *attr,
 
 		ret = wiphy_estimate_data_rate(wiphy, ies, ies_len, bss,
 						&bss->data_rate);
-		if (ret < 0 && ret != -ENETUNREACH)
+		if (ret < 0 && ret != -ENOTSUP)
 			l_warn("wiphy_estimate_data_rate() failed");
 	}
 
-- 
2.34.1


  reply	other threads:[~2024-04-15 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 15:11 [PATCH 1/3] band: return -ENOTSUP when RSSI is too low for rate estimation James Prestwood
2024-04-15 15:11 ` James Prestwood [this message]
2024-04-15 15:11 ` [PATCH 3/3] wiphy: include MAC of BSS with invalid HE capabilities James Prestwood
2024-04-15 18:47 ` [PATCH 1/3] band: return -ENOTSUP when RSSI is too low for rate estimation Denis Kenzior
2024-04-15 19:01   ` James Prestwood
2024-04-15 19:07     ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415151130.40389-2-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox